output: add reflections #1501
Merged
output: add reflections #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
requested review from
lahm86,
walkawayy and
aredfan
and removed request for
a team
walkawayy
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
LGTM! The only things I noticed were:
- Save crystal collision seems to be broken. I didn't have time to figure out when it broke, but I think it's a separate issue. Maybe with the bounds refactor?
- Lara's braid doesn't turn solid with her head and continues moving. Considering the OG game never had a braid, this can probably be a separate issue for future enhancement.
| @@ -571,6 +571,7 @@ Not all options are turned on by default. Refer to `TR1X_ConfigTool.exe` for det | |||
| - added contextual arrows to menu options | |||
| - added support for animated room sprites, which also restores intended behavior in, for example, The Cistern room 0 | |||
| - added skybox support, with a default option provided for Lost Valley, Colosseum and Obelisk of Khamoon; custom level builders can use object slot `184` | |||
| - added reflections of Midas Hand death animation and savegame crystals | |||
There was a problem hiding this comment.
I think added reflections to Midas Hand death animation and savegame crystals makes more sense
|
The crystals and midas reflections look excellent to me, they are reflecting the skyboxes even. The ingame reflections option is working as expected when enabled or disabled. There's a new regression, the game has stopped drawing bars, rotating 3D pickups, ammo counter and ammo sprites. |
aredfan
approved these changes
Sep 12, 2024
Resolves #154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Resolves #154.
The tint of the save game crystals is different from the PS1 version because of how the crystal object is configured on the PC. Addressing this difference involves data changes that are beyond the scope of this pull request.
It doesn't affect the fly cheat.
Demo video: https://home.wind.garden/serve/pub/reflections.mp4