Phaser refactor

[rr-]

Checklist

• I have read the coding conventions
• I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

• Removes .param = 0 from GAMEFLOW_COMMAND assignments, as it's not used by the consumers and is okay to be left uninitialized.

• Renames GF_PHASE_CONTINUE to GF_CONTINUE_SEQUENCE, as the way it was used was never about the phases but rather referred to letting the game carry on executing current game flow sequence.

• Removes GF_PHASE_BREAK enum member in favor of a new struct, PHASE_CONTROL as explained in the next point.

• Tidies up the nomenclature:

  • Phaser control routine result - status whether to continue the current phase, along with an optional game flow command to run afterwards. This is the PHASE_CONTROL struct.
  • Game flow action - the global action to perform, such as exit the game, play a level etc. (This prompted a rename of GAMEFLOW_COMMAND.command member to .action.)
  • Game flow command - a game flow action with an optional parameter.
  • Game flow sequence - a sequence of steps associated with playing a single level. This can be adding items to inventory, playing a cutscene, showing the level stats screen etc.

[rr-]

Note to reviewers – should be an easy no-op change.

• GF_PHASE_CONTINUE got changed to (PHASE_CONTROL){.end = false} within phasers
• GF_PHASE_BREAK got changed to (PHASE_CONTROL){.end = true, .command = {.action = GF_CONTINUE_SEQUENCE}} within phasers
• And most importantly, we got rid of the

      if (command.action == GF_PHASE_BREAK) {
          command.action = GF_CONTINUE_SEQUENCE;
      }

  semi-hack in Phase_Run which mixed the phaser flow with the game flow.

TBH I'm not sure about the last commit, since the same conclusion that led to making it, can now be drawn about the GF_CONTINUE_SEQUENCE which does the same kind of mixing in GameFlow_InterpretSequence (game flow commands and game sequences) as GF_PHASE_BREAK used to in Phase_Control. I do have a feeling that the proposed design is cleaner, though.

[walkawayy]

LGTM. Didn't notice any issues while testing.

[rr-]

Merged manually: f4dd3fb