data: switch from WEBP to JPEG #1469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
requested review from
lahm86,
walkawayy and
aredfan
and removed request for
a team
walkawayy
reviewed
Aug 30, 2024
rr-
force-pushed
the
webp-to-jpeg
branch
2 times, most recently
from
2083dfd to
b32592a
Compare
walkawayy
approved these changes
Aug 30, 2024
lahm86
approved these changes
Aug 31, 2024
|
With the recent improvements on develop and #1470 the savings of this pull request went down to 15 milliseconds (130 ms vs 115 ms). I'll hold on for a bit longer to see if we can do better on other fronts prior to making this switch. |
|
All in all I don't think it's worth it anymore as the savings aren't so dramatic with the recent improvements on develop – especially considering the file size increase. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The files appear identical visually, but the title menu loads much faster with this format. On my machine it goes down from 236 ms to around 150 ms. However, this bloats the asset size by 34% (9.4 MiB compared to 7.0 MiB).