Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: build every pull request #1466

Merged
merged 1 commit into from
Aug 30, 2024
Merged

build: build every pull request #1466

merged 1 commit into from
Aug 30, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Aug 30, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

This will simplify the testing process for @LostArtefacts/qa. After merging this PR, each new pull request will include four additional checks: builds for Linux, Windows, Windows installer, and macOS. These are release builds and do not include debug symbols. Although accessing the builds is somewhat complicated, the benefit is that the process becomes automated and will apply to all pull requests and contributors. Here's a video showing where to find them

2024-08-30.18-48-30.mp4

@rr- rr- added the Internal The invisible stuff label Aug 30, 2024
@rr- rr- added this to the 4.4 milestone Aug 30, 2024
@rr- rr- self-assigned this Aug 30, 2024
@rr- rr- requested review from a team as code owners August 30, 2024 16:51
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team August 30, 2024 16:51
@rr-
Copy link
Collaborator Author

rr- commented Aug 30, 2024

I think the failing macOS job has to do with me pushing this pull request from my fork, and can be safely ignored.

@walkawayy
Copy link
Collaborator

walkawayy commented Aug 30, 2024

Amazing! This will be super useful. The only issue I noticed is the Mac signing process again. :/ That thing is always causing problems.

https://github.com/LostArtefacts/TR1X/actions/runs/10636314044/job/29487839947#step:2:30

EDIT: Oh nice about the Mac issue. LGTM!

Copy link
Collaborator

@aredfan aredfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to follow the steps in the video and download a build.

@rr- Thank you very much for working to make this possible, much appreciated. 👍

@rr-
Copy link
Collaborator Author

rr- commented Aug 30, 2024

It turns out that PRs from forks in GitHub Actions won't be able to use the upstream repository secrets, as explained here: https://github.com/orgs/community/discussions/50161. While workarounds exist, they are risky. Since Mac builds are the only ones that require secrets, I think I'll just remove Mac builds from this process. This won't affect the develop snapshots and regular releases.

@rr- rr- merged commit 3ef5a77 into LostArtefacts:develop Aug 30, 2024
5 checks passed
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal The invisible stuff TR1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants