inventory: fix Lara not saying "no" when using Scion #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walkawayy
added
OG bug
lahm86
reviewed
Apr 9, 2024
There was a problem hiding this comment.
LGTM.
One thing I spotted, which I missed in #1267, is that there is a redundant assignment in the receptacle checks in lara.c. Line 428 isn't needed.
ITEM_INFO *item = &g_Items[receptacle_item_number];
May be worth removing as part of this as it's still a related issue.
rr-
approved these changes
Apr 9, 2024
lahm86
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1278.
Checklist
Description
Fixed Lara not saying "no" when using the Scion incorrectly. She will now say "no" when using the Scion on nothing, keyholes, puzzle holes, and Midas hands.