Add OSD messages + rework game strings #1285
Conversation
rr-
requested review from
a team,
eikehein,
lahm86 and
walkawayy
and removed request for
a team
There was a problem hiding this comment.
Only noticed one issue. Everything else seems to work great! Only one question besides the bug I commented, is the console supposed to advance its timer in the inventory? If you use a give guns or some cheat in the inventory, the console log never disappears. This may be intended, but I wanted to bring it up just in case.
src/game/shell.c
Outdated
| Config_Write(); | ||
| } | ||
|
|
||
| if (g_InputDB.toggle_fps_counter) { | ||
| g_Config.rendering.enable_fps_counter ^= true; | ||
| Console_Log( | ||
| g_Config.rendering.enable_perspective_filter |
There was a problem hiding this comment.
This is the only bug I noticed. The FPS message is incorrectly linked to the enable_perspective_filter option.
CHANGELOG.md
Outdated
| @@ -14,6 +14,7 @@ | |||
| - added the ability to move the look camera while targeting an enemy in combat (#1187) | |||
| - added the ability to skip fade-out in stats screens | |||
| - added support for animated room sprites in custom levels and an option to animate plant sprites in The Cistern and Tomb of Tihocan (#449) | |||
| - added OSD messages for certain actions (#1220) | |||
There was a problem hiding this comment.
Might be worth writing out on screen display or console. Tbh, I didn't even know what OSD was at first til I googled it lol.
The text takes long time to disappear but eventually it does. The time is the same both inside and outside the inventory. I noticed it's possible to use the item cheat in the title menu which does not make sense. I'll fix that. |
There was a problem hiding this comment.
Looks great.
One other cheat I thought of was opening doors while in fly mode - Door_OpenNearest in door.c. Might be awkward though to log all the activated doors - maybe just a single general message if it succeeds or not?
Also, is it worth perhaps adding a table in GAMEFLOW.md with the available string definitions? Otherwise level builders may need to refer to old gameflow files if they are looking to override any.
I thought about this, and I've changed the IMO this isn't the cleanest approach. I can easily see it breaking when we expect it the least, so if you can think of a way to land this table in Added messages for the door cheat – good catch :) |
Checklist
Description
Resolves #1220