IceBoxUpdate #341
IceBoxUpdate #341
Conversation
|
Warning Rate limit exceeded@Flybik has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 3 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Обзор измененийWalkthroughВ репозитории добавлена новая конфигурация игровой карты Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
Статус: Требуется одобрение
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
Resources/Prototypes/_LostParadise/Maps/icebox.yml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Resources/Prototypes/_LostParadise/Maps/icebox.yml (1)
Pattern **/*.yml: так же в прототипах запрещены любые переводы на русский. Только на английском или ссылкой на перевод.
Все добавляемые прототипы должны быть в нашей папке.
Никогда не предлагать ничего по отступам
При удалении дополнительного дополнения по типу prob:, можно оставить оригинальную часть с - id:.
🪛 yamllint (1.35.1)
Resources/Prototypes/_LostParadise/Maps/icebox.yml
[error] 20-20: too many spaces inside brackets
(brackets)
[error] 20-20: too many spaces inside brackets
(brackets)
[error] 21-21: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 70-70: too many spaces inside brackets
(brackets)
[error] 70-70: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 74-74: too many spaces inside brackets
(brackets)
[error] 74-74: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
[warning] 76-76: missing starting space in comment
(comments)
[error] 77-77: too many spaces inside brackets
(brackets)
[error] 77-77: too many spaces inside brackets
(brackets)
[error] 78-78: too many spaces inside brackets
(brackets)
[error] 78-78: too many spaces inside brackets
(brackets)
[error] 79-79: trailing spaces
(trailing-spaces)
[error] 80-80: too many blank lines
(1 > 0) (empty-lines)
🔇 Additional comments (1)
Resources/Prototypes/_LostParadise/Maps/icebox.yml (1)
17-78: Необходимо проверить баланс должностей
Рекомендуется проверить баланс количества должностей относительно минимального количества игроков (20):
- Большое количество руководящих должностей (Captain, HoP, CE, CMO, RD, HoS, QM) для малого количества игроков
- Возможен дисбаланс между отделами (например, 3-4 медика при 2-4 офицерах службы безопасности)
✅ Verification successful
Баланс должностей соответствует размеру карты и минимальному количеству игроков
Сравнение с другими картами того же размера (minPlayers: 20) показывает, что:
- Количество руководящих должностей (7) стандартно для всех карт этого размера
- Соотношение между отделами сбалансировано:
- Медицина: 3-4 врача + 2-4 интерна (аналогично другим картам)
- Охрана: 2-4 офицера + 1-2 кадета (соответствует нормам)
- Инженерия: 2-4 инженера + 2-4 ассистента (стандартное распределение)
- Уникальные роли (Zookeeper, MartialArtist) и дополнительные должности (MedicalBorg, Brigmedic) добавляют разнообразие, не нарушая общий баланс
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Проверка похожих конфигураций карт для сравнения баланса должностей
rg -l "type: gameMap" | xargs rg "minPlayers: 20" -C 50
Length of output: 14015
🧰 Tools
🪛 yamllint (1.35.1)
[error] 20-20: too many spaces inside brackets
(brackets)
[error] 20-20: too many spaces inside brackets
(brackets)
[error] 21-21: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 70-70: too many spaces inside brackets
(brackets)
[error] 70-70: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 74-74: too many spaces inside brackets
(brackets)
[error] 74-74: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
[warning] 76-76: missing starting space in comment
(comments)
[error] 77-77: too many spaces inside brackets
(brackets)
[error] 77-77: too many spaces inside brackets
(brackets)
[error] 78-78: too many spaces inside brackets
(brackets)
[error] 78-78: too many spaces inside brackets
(brackets)
| #LOST PARADISE | ||
| LPPBlueShieldOfficer: [ 1, 1 ] | ||
| LPPAdjutant: [ 1, 1 ] | ||
|
|
||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Требуется исправить форматирование
Обнаружены проблемы с форматированием:
- Отсутствует пробел после # в комментарии "LOST PARADISE"
- Лишние пустые строки в конце файла
- Лишние пробелы в конце строки 79
- #LOST PARADISE
+ # LOST PARADISECommittable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 yamllint (1.35.1)
[warning] 76-76: missing starting space in comment
(comments)
[error] 77-77: too many spaces inside brackets
(brackets)
[error] 77-77: too many spaces inside brackets
(brackets)
[error] 78-78: too many spaces inside brackets
(brackets)
[error] 78-78: too many spaces inside brackets
(brackets)
[error] 79-79: trailing spaces
(trailing-spaces)
[error] 80-80: too many blank lines
(1 > 0) (empty-lines)
There was a problem hiding this comment.
Я исправил это в новых коммитах
| - type: gameMap | ||
| id: LPPIceBox | ||
| mapName: 'NTS АйсБокс' | ||
| mapPath: /Maps/_LostParadise/LPPIceBox.yml | ||
| minPlayers: 20 |
There was a problem hiding this comment.
Требуется перевод названия карты на английский язык
Согласно правилам кодирования, использование русского текста в прототипах запрещено. Необходимо изменить mapName на английский вариант.
- mapName: 'NTS АйсБокс'
+ mapName: 'NTS IceBox'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - type: gameMap | |
| id: LPPIceBox | |
| mapName: 'NTS АйсБокс' | |
| mapPath: /Maps/_LostParadise/LPPIceBox.yml | |
| minPlayers: 20 | |
| - type: gameMap | |
| id: LPPIceBox | |
| mapName: 'NTS IceBox' | |
| mapPath: /Maps/_LostParadise/LPPIceBox.yml | |
| minPlayers: 20 |
There was a problem hiding this comment.
Так и задумано. Название должно быть на русском.
There was a problem hiding this comment.
@Flybik Понятно, спасибо за пояснение.
| - type: StationNameSetup | ||
| mapNameTemplate: '{0} NTS АйсБокс {1}' | ||
| nameGenerator: | ||
| !type:NanotrasenNameGenerator | ||
| prefixCreator: 'DSJJ' |
There was a problem hiding this comment.
Требуется перевод шаблона названия станции на английский язык
В шаблоне названия станции используется русский текст, что противоречит правилам.
- mapNameTemplate: '{0} NTS АйсБокс {1}'
+ mapNameTemplate: '{0} NTS IceBox {1}'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - type: StationNameSetup | |
| mapNameTemplate: '{0} NTS АйсБокс {1}' | |
| nameGenerator: | |
| !type:NanotrasenNameGenerator | |
| prefixCreator: 'DSJJ' | |
| - type: StationNameSetup | |
| mapNameTemplate: '{0} NTS IceBox {1}' | |
| nameGenerator: | |
| !type:NanotrasenNameGenerator | |
| prefixCreator: 'DSJJ' |
There was a problem hiding this comment.
Так и задумано. Название должно быть на русском.
There was a problem hiding this comment.
@Flybik Понятно, спасибо за разъяснение.
github-actions
bot
added
Статус: Конфликт
|
В этом ПР'е есть конфликты, пожалуйста, устраните их, прежде чем мы сможем оценить ваш ПР. |
Описание обновления:
Добавил в проект полностью рабочую карту на псевдопланете "АйсБокс", так же шаттл
Медиа
Проверки
Изменения
🆑 JayJacobs