Возвращение карты Box #311
Conversation
DarkSide-droids
requested review from
BL02DL,
Flybik and
Evgencheg
as code owners
|
""" ПрохождениеВ этом запросе на изменение был добавлен новый YAML файл конфигурации для игровой карты под названием "NTS Коробка". Файл определяет карту типа Изменения
Диаграмма последовательностиsequenceDiagram
participant Player
participant GameServer
participant MapConfig
Player->>GameServer: Запрос на подключение
GameServer->>MapConfig: Проверка конфигурации карты
MapConfig-->>GameServer: Возврат конфигурации карты
GameServer-->>Player: Подключение к карте "NTS Коробка"
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
Статус: Требуется одобрение
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
- Resources/Prototypes/_LostParadise/Maps/box.yml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Resources/Prototypes/_LostParadise/Maps/box.yml (1)
Pattern **/*.yml: так же в прототипах запрещены любые переводы на русский. Только на английском или ссылкой на перевод.
Все добавляемые прототипы должны быть в нашей папке.
Никогда не предлагать ничего по отступам
При удалении дополнительного дополнения по типу prob:, можно оставить оригинальную часть с - id:.
🪛 yamllint
Resources/Prototypes/_LostParadise/Maps/box.yml
[error] 63-63: too many blank lines
(1 > 0) (empty-lines)
🔇 Additional comments (2)
Resources/Prototypes/_LostParadise/Maps/box.yml (2)
17-62: 🧹 Nitpick (assertive)
Проверьте баланс рабочих мест
Конфигурация содержит очень большое количество позиций для станции. Убедитесь, что:
- Количество позиций соответствует размеру карты
- Баланс между отделами оптимален
- Значение minPlayers (50) соответствует сумме минимального количества игроков для всех обязательных позиций
Особое внимание следует обратить на:
- 5 инженеров + 3 атмосферных техника
- 4 медицинских доктора + 4 интерна
- 5 офицеров безопасности + 4 кадета
1-63: Проверьте расположение файла
Согласно правилам проекта, все прототипы должны находиться в специальной папке. Убедитесь, что путь Resources/Prototypes/_LostParadise/Maps/box.yml соответствует требованиям проекта.
✅ Verification successful
Let me check the project's structure to verify if this is indeed the correct location for map prototypes.
Let me check the content of the main README to see if there are any specific guidelines about map organization.
Расположение файла корректно
Файл находится в правильной директории Resources/Prototypes/_LostParadise/Maps/. Это подтверждается следующими фактами:
- Проект имеет четкую структуру с выделенной папкой
_LostParadiseдля своих прототипов - Другие карты проекта также находятся в этой же директории (asterisk.yml, normandy.yml и др.)
- Структура соответствует организации остальных прототипов проекта
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Проверяем существование других прототипов карт в той же директории
fd -e yml -e yaml . Resources/Prototypes/_LostParadise/Maps/
Length of output: 682
Script:
#!/bin/bash
# Check for other map prototypes in the main Resources/Prototypes directory
fd -e yml -e yaml . Resources/Prototypes/Maps/
# Check if there's any documentation about map file organization
fd README -t f
Length of output: 1014
Script:
#!/bin/bash
# Check README content for any mapping guidelines
cat README.md
# Also check if there are any other _LostParadise prototypes in other categories
fd . Resources/Prototypes/_LostParadise -t d
Length of output: 14387
🧰 Tools
🪛 yamllint
[error] 63-63: too many blank lines
(1 > 0) (empty-lines)
DarkSide-droids
changed the title
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
Resources/Prototypes/_LostParadise/Maps/box.yml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Resources/Prototypes/_LostParadise/Maps/box.yml (1)
Pattern **/*.yml: так же в прототипах запрещены любые переводы на русский. Только на английском или ссылкой на перевод.
Все добавляемые прототипы должны быть в нашей папке.
Никогда не предлагать ничего по отступам
При удалении дополнительного дополнения по типу prob:, можно оставить оригинальную часть с - id:.
🪛 yamllint
Resources/Prototypes/_LostParadise/Maps/box.yml
[error] 20-20: too many spaces inside brackets
(brackets)
[error] 20-20: too many spaces inside brackets
(brackets)
[error] 21-21: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 29-29: too many spaces inside brackets
(brackets)
[error] 29-29: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 34-34: too many spaces inside brackets
(brackets)
[error] 34-34: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 41-41: too many spaces inside brackets
(brackets)
[error] 41-41: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 49-49: too many spaces inside brackets
(brackets)
[error] 49-49: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 59-59: too many spaces inside brackets
(brackets)
[error] 59-59: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 64-64: too many spaces inside brackets
(brackets)
[error] 64-64: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 70-70: too many spaces inside brackets
(brackets)
[error] 70-70: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[warning] 72-72: missing starting space in comment
(comments)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 74-74: too many spaces inside brackets
(brackets)
[error] 74-74: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 76-76: too many blank lines
(1 > 0) (empty-lines)
🔇 Additional comments (1)
Resources/Prototypes/_LostParadise/Maps/box.yml (1)
17-75: Конфигурация должностей выглядит корректно
Структура должностей хорошо организована по категориям, включая пользовательские должности с префиксом LPP.
🧰 Tools
🪛 yamllint
[error] 20-20: too many spaces inside brackets
(brackets)
[error] 20-20: too many spaces inside brackets
(brackets)
[error] 21-21: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 29-29: too many spaces inside brackets
(brackets)
[error] 29-29: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 34-34: too many spaces inside brackets
(brackets)
[error] 34-34: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 41-41: too many spaces inside brackets
(brackets)
[error] 41-41: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 49-49: too many spaces inside brackets
(brackets)
[error] 49-49: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 59-59: too many spaces inside brackets
(brackets)
[error] 59-59: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 64-64: too many spaces inside brackets
(brackets)
[error] 64-64: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 70-70: too many spaces inside brackets
(brackets)
[error] 70-70: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[warning] 72-72: missing starting space in comment
(comments)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 74-74: too many spaces inside brackets
(brackets)
[error] 74-74: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
| - type: StationEmergencyShuttle | ||
| emergencyShuttlePath: /Maps/Shuttles/DeltaV/NTES_UCLB.yml |
There was a problem hiding this comment.
💡 Codebase verification
Путь к файлу шаттла корректен
Файл NTES_UCLB.yml существует в репозитории, но указанный в конфигурации путь /Maps/Shuttles/DeltaV/NTES_UCLB.yml следует изменить на Resources/Maps/Shuttles/DeltaV/NTES_UCLB.yml, чтобы он соответствовал реальному расположению файла.
🔗 Analysis chain
Проверьте существование файла шаттла
Необходимо убедиться, что указанный путь к файлу шаттла корректен.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Проверка существования файла шаттла
fd "NTES_UCLB.yml" --type f
Length of output: 72
| - type: gameMap | ||
| id: LPPBox | ||
| mapName: 'NTS Коробка' | ||
| mapPath: /Maps/_LostParadise/LPPBox.yml | ||
| minPlayers: 30 |
There was a problem hiding this comment.
Требуется использовать английский язык в названии карты
Согласно правилам проекта, в прототипах запрещены переводы на русский язык. Пожалуйста, измените название карты на английский вариант.
- mapName: 'NTS Коробка'
+ mapName: 'NTS Box'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - type: gameMap | |
| id: LPPBox | |
| mapName: 'NTS Коробка' | |
| mapPath: /Maps/_LostParadise/LPPBox.yml | |
| minPlayers: 30 | |
| - type: gameMap | |
| id: LPPBox | |
| mapName: 'NTS Box' | |
| mapPath: /Maps/_LostParadise/LPPBox.yml | |
| minPlayers: 30 |
| - type: StationNameSetup | ||
| mapNameTemplate: '{0} NTS Коробка {1}' | ||
| nameGenerator: | ||
| !type:NanotrasenNameGenerator | ||
| prefixCreator: '17' |
There was a problem hiding this comment.
Требуется использовать английский язык в шаблоне названия
В шаблоне названия станции используется русский текст, что противоречит правилам проекта.
- mapNameTemplate: '{0} NTS Коробка {1}'
+ mapNameTemplate: '{0} NTS Box {1}'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - type: StationNameSetup | |
| mapNameTemplate: '{0} NTS Коробка {1}' | |
| nameGenerator: | |
| !type:NanotrasenNameGenerator | |
| prefixCreator: '17' | |
| - type: StationNameSetup | |
| mapNameTemplate: '{0} NTS Box {1}' | |
| nameGenerator: | |
| !type:NanotrasenNameGenerator | |
| prefixCreator: '17' |
Описание обновления:
Медиа
Nope
Проверки
Изменения
🆑 MrDarkSide and JayJaycobs