Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H_Maps #308

Merged
merged 2 commits into from
Oct 28, 2024
Merged

H_Maps #308

merged 2 commits into from
Oct 28, 2024

Conversation

BL02DL
Copy link
Collaborator

@BL02DL BL02DL commented Oct 28, 2024

image

Описание обновления: Хеллоуиновские карты

Медиа

Проверки

  • PR завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.
  • Я не добавлял контент нарушающий чужие авторские права.
  • Я добавил свой контент только в папку _LostParadise(только если вы не меняете оригинальный код).
  • Я не добавлял переводы в прототипы, а сделал их с помощью скрипта translations.bat в Tools/SS14_RU.

Изменения

🆑 BL02DL

  • remove: Убрано веселье!
  • add: Добавлены страшилки!

@BL02DL BL02DL added Изменения: YML Изменяет какие-либо файлы .yml Приоритет: 1-Максимальный РЕШИТЬ НЕМЕДЛЕННО! Размер: 5-Микро Для очень очень маленьких ПР'ов/баг репортов labels Oct 28, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2024 •
edited
Loading

Walkthrough

В данном пулл-запросе добавлены новые игровые карты и обновлены существующие конфигурации. В классе PostMapInitTest добавлены четыре новых идентификатора карт, начинающихся с "H_". Также созданы новые YAML-файлы для карт "Астериск", "Керберос", "Нормандия" и "Пеббл", каждая из которых имеет уникальные настройки, включая минимальное и максимальное количество игроков, а также описание доступных ролей на станциях. Кроме того, обновлена конфигурация пула карт, чтобы отразить изменения идентификаторов.

Changes

Файл Изменения
Content.IntegrationTests/Tests/PostMapInitTest.cs Добавлены новые идентификаторы карт: "H_LPPKerberos", "H_LPPAsterisk", "H_LPPNormandy", "H_LPPPebble" в массив GameMaps.
Resources/Prototypes/_LostParadise/Maps/Hell/H_asterisk.yml Добавлена новая конфигурация карты: type: gameMap, id: H_LPPAsterisk, mapName: 'Астериск', minPlayers: 20, maxPlayers: 70, с настройками станций и доступными ролями.
Resources/Prototypes/_LostParadise/Maps/Hell/H_kerberos.yml Добавлена новая конфигурация карты: type: gameMap, id: H_LPPKerberos, mapName: 'NS Керберос', minPlayers: 30, с настройками станций и доступными ролями.
Resources/Prototypes/_LostParadise/Maps/Hell/H_normandy.yml Добавлена новая конфигурация карты: type: gameMap, id: H_LPPNormandy, mapName: 'N7 Нормандия', minPlayers: 20, с настройками станций и доступными ролями.
Resources/Prototypes/_LostParadise/Maps/Hell/H_pebble.yml Добавлена новая конфигурация карты: type: gameMap, id: H_LPPPebble, mapName: 'Пеббл', minPlayers: 0, maxPlayers: 30, с настройками станций и доступными ролями.
Resources/Prototypes/_LostParadise/Maps/Pools/LostParadiseMapPool.yml Обновлены идентификаторы карт: LPPAsterisk → H_LPPAsterisk, LPPPebble → H_LPPPebble, LPPNormandy → H_LPPNormandy, LPPKerberos → H_LPPKerberos; удален LPPSubmarine.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@BL02DL BL02DL requested a review from Evgencheg October 28, 2024 14:19
@github-actions github-actions bot added the Статус: Требуется одобрение Ожидание разработчиков для принятия решений label Oct 28, 2024
@github-actions github-actions bot added the Изменения: C# Изменяет какие-либо файлы .cs label Oct 28, 2024
coderabbitai[bot]
coderabbitai bot requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 11

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between cc81578 and 2a11b4e.

📒 Files selected for processing (6)
  • Content.IntegrationTests/Tests/PostMapInitTest.cs (1 hunks)
  • Resources/Prototypes/_LostParadise/Maps/Hell/H_asterisk.yml (1 hunks)
  • Resources/Prototypes/_LostParadise/Maps/Hell/H_kerberos.yml (1 hunks)
  • Resources/Prototypes/_LostParadise/Maps/Hell/H_normandy.yml (1 hunks)
  • Resources/Prototypes/_LostParadise/Maps/Hell/H_pebble.yml (1 hunks)
  • Resources/Prototypes/_LostParadise/Maps/Pools/LostParadiseMapPool.yml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
Resources/Prototypes/_LostParadise/Maps/Hell/H_asterisk.yml (1)

Pattern **/*.yml: так же в прототипах запрещены любые переводы на русский. Только на английском или ссылкой на перевод.

Все добавляемые прототипы должны быть в нашей папке.

Никогда не предлагать ничего по отступам

При удалении дополнительного дополнения по типу prob:, можно оставить оригинальную часть с - id:.

Resources/Prototypes/_LostParadise/Maps/Hell/H_kerberos.yml (1)

Pattern **/*.yml: так же в прототипах запрещены любые переводы на русский. Только на английском или ссылкой на перевод.

Все добавляемые прототипы должны быть в нашей папке.

Никогда не предлагать ничего по отступам

При удалении дополнительного дополнения по типу prob:, можно оставить оригинальную часть с - id:.

Resources/Prototypes/_LostParadise/Maps/Hell/H_normandy.yml (1)

Pattern **/*.yml: так же в прототипах запрещены любые переводы на русский. Только на английском или ссылкой на перевод.

Все добавляемые прототипы должны быть в нашей папке.

Никогда не предлагать ничего по отступам

При удалении дополнительного дополнения по типу prob:, можно оставить оригинальную часть с - id:.

Resources/Prototypes/_LostParadise/Maps/Hell/H_pebble.yml (1)

Pattern **/*.yml: так же в прототипах запрещены любые переводы на русский. Только на английском или ссылкой на перевод.

Все добавляемые прототипы должны быть в нашей папке.

Никогда не предлагать ничего по отступам

При удалении дополнительного дополнения по типу prob:, можно оставить оригинальную часть с - id:.

Resources/Prototypes/_LostParadise/Maps/Pools/LostParadiseMapPool.yml (1)

Pattern **/*.yml: так же в прототипах запрещены любые переводы на русский. Только на английском или ссылкой на перевод.

Все добавляемые прототипы должны быть в нашей папке.

Никогда не предлагать ничего по отступам

При удалении дополнительного дополнения по типу prob:, можно оставить оригинальную часть с - id:.

🪛 yamllint
Resources/Prototypes/_LostParadise/Maps/Hell/H_asterisk.yml

[warning] 25-25: missing starting space in comment

(comments)

[warning] 25-25: comment not indented like content

(comments-indentation)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 29-29: too many spaces inside brackets

(brackets)

[error] 29-29: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 32-32: too many spaces inside brackets

(brackets)

[error] 32-32: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 34-34: too many spaces inside brackets

(brackets)

[error] 34-34: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[warning] 37-37: missing starting space in comment

(comments)

[warning] 37-37: comment not indented like content

(comments-indentation)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[warning] 39-39: too few spaces before comment

(comments)

[warning] 39-39: missing starting space in comment

(comments)

[error] 40-40: too many spaces inside brackets

(brackets)

[error] 40-40: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[warning] 42-42: missing starting space in comment

(comments)

[warning] 42-42: comment not indented like content

(comments-indentation)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 44-44: too many spaces inside brackets

(brackets)

[error] 44-44: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[warning] 48-48: missing starting space in comment

(comments)

[warning] 48-48: comment not indented like content

(comments-indentation)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 51-51: too many spaces inside brackets

(brackets)

[error] 51-51: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[warning] 55-55: missing starting space in comment

(comments)

[warning] 55-55: comment not indented like content

(comments-indentation)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 57-57: too many spaces inside brackets

(brackets)

[error] 57-57: too many spaces inside brackets

(brackets)

[error] 58-58: too many spaces inside brackets

(brackets)

[error] 58-58: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 62-62: too many spaces inside brackets

(brackets)

[error] 62-62: too many spaces inside brackets

(brackets)

[warning] 62-62: too few spaces before comment

(comments)

[warning] 63-63: missing starting space in comment

(comments)

[warning] 63-63: comment not indented like content

(comments-indentation)

[error] 64-64: too many spaces inside brackets

(brackets)

[error] 64-64: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 67-67: too many spaces inside brackets

(brackets)

[error] 67-67: too many spaces inside brackets

(brackets)

[warning] 68-68: missing starting space in comment

(comments)

[warning] 68-68: comment not indented like content

(comments-indentation)

[error] 69-69: too many spaces inside brackets

(brackets)

[error] 69-69: too many spaces inside brackets

(brackets)

[warning] 70-70: missing starting space in comment

(comments)

[warning] 70-70: comment not indented like content

(comments-indentation)

[error] 71-71: too many spaces inside brackets

(brackets)

[error] 71-71: too many spaces inside brackets

(brackets)

[error] 72-72: too many spaces inside brackets

(brackets)

[error] 72-72: too many spaces inside brackets

(brackets)

[error] 73-73: too many spaces inside brackets

(brackets)

[error] 73-73: too many spaces inside brackets

(brackets)

[warning] 74-74: missing starting space in comment

(comments)

[warning] 74-74: comment not indented like content

(comments-indentation)

[error] 75-75: too many spaces inside brackets

(brackets)

[error] 75-75: too many spaces inside brackets

(brackets)

[error] 76-76: too many spaces inside brackets

(brackets)

[error] 76-76: too many spaces inside brackets

(brackets)

[error] 77-77: too many spaces inside brackets

(brackets)

[error] 77-77: too many spaces inside brackets

(brackets)

Resources/Prototypes/_LostParadise/Maps/Hell/H_kerberos.yml

[error] 22-22: too many spaces inside brackets

(brackets)

[error] 22-22: too many spaces inside brackets

(brackets)

[error] 23-23: too many spaces inside brackets

(brackets)

[error] 24-24: too many spaces inside brackets

(brackets)

[error] 24-24: too many spaces inside brackets

(brackets)

[error] 25-25: too many spaces inside brackets

(brackets)

[error] 25-25: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 32-32: too many spaces inside brackets

(brackets)

[error] 32-32: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[error] 37-37: too many spaces inside brackets

(brackets)

[error] 37-37: too many spaces inside brackets

(brackets)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 40-40: too many spaces inside brackets

(brackets)

[error] 40-40: too many spaces inside brackets

(brackets)

[error] 42-42: too many spaces inside brackets

(brackets)

[error] 42-42: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 44-44: too many spaces inside brackets

(brackets)

[error] 44-44: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 48-48: too many spaces inside brackets

(brackets)

[error] 48-48: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 51-51: too many spaces inside brackets

(brackets)

[error] 51-51: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 55-55: too many spaces inside brackets

(brackets)

[error] 55-55: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 57-57: too many spaces inside brackets

(brackets)

[error] 57-57: too many spaces inside brackets

(brackets)

[error] 58-58: too many spaces inside brackets

(brackets)

[error] 58-58: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 62-62: too many spaces inside brackets

(brackets)

[error] 62-62: too many spaces inside brackets

(brackets)

[error] 63-63: too many spaces inside brackets

(brackets)

[error] 63-63: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 67-67: too many spaces inside brackets

(brackets)

[error] 67-67: too many spaces inside brackets

(brackets)

[error] 68-68: too many spaces inside brackets

(brackets)

[error] 68-68: too many spaces inside brackets

(brackets)

[error] 69-69: too many spaces inside brackets

(brackets)

[error] 69-69: too many spaces inside brackets

(brackets)

[error] 71-71: too many spaces inside brackets

(brackets)

[error] 71-71: too many spaces inside brackets

(brackets)

[error] 72-72: too many spaces inside brackets

(brackets)

[error] 72-72: too many spaces inside brackets

(brackets)

[error] 73-73: too many spaces inside brackets

(brackets)

[error] 73-73: too many spaces inside brackets

(brackets)

[warning] 74-74: missing starting space in comment

(comments)

[error] 75-75: too many spaces inside brackets

(brackets)

[error] 75-75: too many spaces inside brackets

(brackets)

[error] 76-76: too many spaces inside brackets

(brackets)

[error] 76-76: too many spaces inside brackets

(brackets)

[error] 77-77: too many spaces inside brackets

(brackets)

[error] 77-77: too many spaces inside brackets

(brackets)

Resources/Prototypes/_LostParadise/Maps/Hell/H_normandy.yml

[error] 22-22: too many spaces inside brackets

(brackets)

[error] 22-22: too many spaces inside brackets

(brackets)

[error] 23-23: too many spaces inside brackets

(brackets)

[error] 24-24: too many spaces inside brackets

(brackets)

[error] 24-24: too many spaces inside brackets

(brackets)

[error] 25-25: too many spaces inside brackets

(brackets)

[error] 25-25: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 32-32: too many spaces inside brackets

(brackets)

[error] 32-32: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[error] 37-37: too many spaces inside brackets

(brackets)

[error] 37-37: too many spaces inside brackets

(brackets)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[error] 42-42: too many spaces inside brackets

(brackets)

[error] 42-42: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 44-44: too many spaces inside brackets

(brackets)

[error] 44-44: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 51-51: too many spaces inside brackets

(brackets)

[error] 51-51: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 55-55: too many spaces inside brackets

(brackets)

[error] 55-55: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 57-57: too many spaces inside brackets

(brackets)

[error] 57-57: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 62-62: too many spaces inside brackets

(brackets)

[error] 62-62: too many spaces inside brackets

(brackets)

[error] 64-64: too many spaces inside brackets

(brackets)

[error] 64-64: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 67-67: too many spaces inside brackets

(brackets)

[error] 67-67: too many spaces inside brackets

(brackets)

[error] 68-68: too many spaces inside brackets

(brackets)

[error] 68-68: too many spaces inside brackets

(brackets)

[error] 70-70: too many spaces inside brackets

(brackets)

[error] 70-70: too many spaces inside brackets

(brackets)

[error] 71-71: too many spaces inside brackets

(brackets)

[error] 71-71: too many spaces inside brackets

(brackets)

[error] 72-72: too many spaces inside brackets

(brackets)

[error] 72-72: too many spaces inside brackets

(brackets)

[warning] 73-73: missing starting space in comment

(comments)

[error] 74-74: too many spaces inside brackets

(brackets)

[error] 74-74: too many spaces inside brackets

(brackets)

[error] 75-75: too many spaces inside brackets

(brackets)

[error] 75-75: too many spaces inside brackets

(brackets)

[error] 76-76: too many spaces inside brackets

(brackets)

[error] 76-76: too many spaces inside brackets

(brackets)

Resources/Prototypes/_LostParadise/Maps/Hell/H_pebble.yml

[warning] 20-20: missing starting space in comment

(comments)

[warning] 20-20: comment not indented like content

(comments-indentation)

[error] 21-21: too many spaces inside brackets

(brackets)

[error] 21-21: too many spaces inside brackets

(brackets)

[error] 22-22: too many spaces inside brackets

(brackets)

[error] 22-22: too many spaces inside brackets

(brackets)

[error] 23-23: too many spaces inside brackets

(brackets)

[error] 23-23: too many spaces inside brackets

(brackets)

[error] 24-24: too many spaces inside brackets

(brackets)

[error] 24-24: too many spaces inside brackets

(brackets)

[error] 25-25: too many spaces inside brackets

(brackets)

[error] 25-25: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces before comma

(commas)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 29-29: too many spaces inside brackets

(brackets)

[error] 29-29: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[warning] 32-32: missing starting space in comment

(comments)

[warning] 32-32: comment not indented like content

(comments-indentation)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 34-34: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[warning] 37-37: missing starting space in comment

(comments)

[warning] 37-37: comment not indented like content

(comments-indentation)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 40-40: too many spaces inside brackets

(brackets)

[error] 40-40: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[error] 42-42: too many spaces inside brackets

(brackets)

[error] 42-42: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[warning] 44-44: missing starting space in comment

(comments)

[warning] 44-44: comment not indented like content

(comments-indentation)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 48-48: too many spaces inside brackets

(brackets)

[error] 48-48: too many spaces inside brackets

(brackets)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[warning] 51-51: missing starting space in comment

(comments)

[warning] 51-51: comment not indented like content

(comments-indentation)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 55-55: too many spaces inside brackets

(brackets)

[error] 55-55: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[warning] 57-57: missing starting space in comment

(comments)

[warning] 57-57: comment not indented like content

(comments-indentation)

[error] 58-58: too many spaces inside brackets

(brackets)

[error] 58-58: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[warning] 62-62: missing starting space in comment

(comments)

[warning] 62-62: comment not indented like content

(comments-indentation)

[error] 63-63: too many spaces inside brackets

(brackets)

[error] 63-63: too many spaces inside brackets

(brackets)

[warning] 64-64: missing starting space in comment

(comments)

[warning] 64-64: comment not indented like content

(comments-indentation)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[warning] 67-67: missing starting space in comment

(comments)

[warning] 67-67: comment not indented like content

(comments-indentation)

[error] 68-68: too many spaces inside brackets

(brackets)

[error] 68-68: too many spaces inside brackets

(brackets)

[error] 69-69: too many spaces inside brackets

(brackets)

[error] 69-69: too many spaces inside brackets

(brackets)

[error] 70-70: too many spaces inside brackets

(brackets)

[error] 70-70: too many spaces inside brackets

(brackets)

Resources/Prototypes/_LostParadise/Maps/Pools/LostParadiseMapPool.yml

[error] 4-4: wrong indentation: expected at least 3

(indentation)

🔇 Additional comments (10)
Resources/Prototypes/_LostParadise/Maps/Pools/LostParadiseMapPool.yml (1)

4-7: Проверка наличия файлов карт с префиксом H_

Изменения соответствуют целям PR по добавлению хэллоуинской тематики. Необходимо убедиться в наличии соответствующих файлов конфигурации карт.

✅ Verification successful

Файлы карт хэллоуинской тематики подтверждены

Проверка показала, что:

  • Все файлы конфигурации хэллоуинских карт существуют в директории Resources/Prototypes/_LostParadise/Maps/Hell/
  • Идентификаторы карт корректно определены в соответствующих файлах конфигурации
  • Структура файлов соответствует существующим картам, с добавлением префикса "H_" для хэллоуинской версии
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of Halloween map configuration files

# Test: Check if all new map files exist
fd "H_LPP(Asterisk|Pebble|Normandy|Kerberos).yml" Resources/Prototypes/_LostParadise/Maps

Length of output: 91

Script:

#!/bin/bash
# Let's try a broader search to understand the map file structure
fd "\.yml$" Resources/Prototypes/_LostParadise/Maps -t f

Length of output: 630

Script:

#!/bin/bash
# Also check if there are any references to these maps in other files
rg "H_LPP(Asterisk|Pebble|Normandy|Kerberos)" --type yaml

Length of output: 1809

Script:

#!/bin/bash
# Check the directory structure
fd . Resources/Prototypes/_LostParadise/Maps -t d

Length of output: 144

🧰 Tools
🪛 yamllint

[error] 4-4: wrong indentation: expected at least 3

(indentation)

Resources/Prototypes/_LostParadise/Maps/Hell/H_pebble.yml (3)

1-6: ⚠️ Potential issue

Требуется перевод названия карты на английский язык

Согласно правилам кодирования, в прототипах запрещены переводы на русский язык. Необходимо использовать английское название.

Примените следующие изменения:

- mapName: 'Пеббл'
+ mapName: 'Pebble'

16-70: 🧹 Nitpick (assertive)

Проверьте баланс ролей для карты в стиле Хэллоуина

Текущая конфигурация ролей выглядит как стандартная станция. Учитывая, что это карта из серии Halloween-themed (согласно целям PR), возможно, стоит:

  1. Добавить специальные роли, связанные с тематикой Хэллоуина
  2. Скорректировать количество определенных ролей (например, увеличить количество охранников из-за повышенной опасности)
  3. Рассмотреть добавление уникальных ролей для этой карты

Хотите, чтобы я предложил специфичную для Хэллоуина конфигурацию ролей?

🧰 Tools
🪛 yamllint

[warning] 20-20: missing starting space in comment

(comments)

[warning] 20-20: comment not indented like content

(comments-indentation)

[error] 21-21: too many spaces inside brackets

(brackets)

[error] 21-21: too many spaces inside brackets

(brackets)

[error] 22-22: too many spaces inside brackets

(brackets)

[error] 22-22: too many spaces inside brackets

(brackets)

[error] 23-23: too many spaces inside brackets

(brackets)

[error] 23-23: too many spaces inside brackets

(brackets)

[error] 24-24: too many spaces inside brackets

(brackets)

[error] 24-24: too many spaces inside brackets

(brackets)

[error] 25-25: too many spaces inside brackets

(brackets)

[error] 25-25: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces before comma

(commas)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 29-29: too many spaces inside brackets

(brackets)

[error] 29-29: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[warning] 32-32: missing starting space in comment

(comments)

[warning] 32-32: comment not indented like content

(comments-indentation)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 34-34: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[warning] 37-37: missing starting space in comment

(comments)

[warning] 37-37: comment not indented like content

(comments-indentation)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 40-40: too many spaces inside brackets

(brackets)

[error] 40-40: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[error] 42-42: too many spaces inside brackets

(brackets)

[error] 42-42: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[warning] 44-44: missing starting space in comment

(comments)

[warning] 44-44: comment not indented like content

(comments-indentation)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 48-48: too many spaces inside brackets

(brackets)

[error] 48-48: too many spaces inside brackets

(brackets)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[warning] 51-51: missing starting space in comment

(comments)

[warning] 51-51: comment not indented like content

(comments-indentation)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 55-55: too many spaces inside brackets

(brackets)

[error] 55-55: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[warning] 57-57: missing starting space in comment

(comments)

[warning] 57-57: comment not indented like content

(comments-indentation)

[error] 58-58: too many spaces inside brackets

(brackets)

[error] 58-58: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[warning] 62-62: missing starting space in comment

(comments)

[warning] 62-62: comment not indented like content

(comments-indentation)

[error] 63-63: too many spaces inside brackets

(brackets)

[error] 63-63: too many spaces inside brackets

(brackets)

[warning] 64-64: missing starting space in comment

(comments)

[warning] 64-64: comment not indented like content

(comments-indentation)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[warning] 67-67: missing starting space in comment

(comments)

[warning] 67-67: comment not indented like content

(comments-indentation)

[error] 68-68: too many spaces inside brackets

(brackets)

[error] 68-68: too many spaces inside brackets

(brackets)

[error] 69-69: too many spaces inside brackets

(brackets)

[error] 69-69: too many spaces inside brackets

(brackets)

[error] 70-70: too many spaces inside brackets

(brackets)

[error] 70-70: too many spaces inside brackets

(brackets)

26-26: ⚠️ Potential issue

Исправьте форматирование в определении роли Chef

В строке есть лишний пробел перед запятой.

Примените следующие изменения:

- Chef: [ 2 , 2 ]
+ Chef: [ 2, 2 ]

Likely invalid or redundant comment.

🧰 Tools
🪛 yamllint

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces before comma

(commas)

[error] 26-26: too many spaces inside brackets

(brackets)

Resources/Prototypes/_LostParadise/Maps/Hell/H_normandy.yml (2)

17-72: 🧹 Nitpick (assertive)

Проверьте баланс ролей для размера карты

Конфигурация ролей выглядит обширной для карты с минимальным количеством игроков 20:

  • Большое количество административных ролей (Captain, HeadOfPersonnel, ChiefEngineer и т.д.)
  • Множество специализированных позиций в каждом отделе

Рекомендуется пересмотреть баланс ролей с учетом минимального количества игроков.

🧰 Tools
🪛 yamllint

[error] 22-22: too many spaces inside brackets

(brackets)

[error] 22-22: too many spaces inside brackets

(brackets)

[error] 23-23: too many spaces inside brackets

(brackets)

[error] 24-24: too many spaces inside brackets

(brackets)

[error] 24-24: too many spaces inside brackets

(brackets)

[error] 25-25: too many spaces inside brackets

(brackets)

[error] 25-25: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 32-32: too many spaces inside brackets

(brackets)

[error] 32-32: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[error] 37-37: too many spaces inside brackets

(brackets)

[error] 37-37: too many spaces inside brackets

(brackets)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[error] 42-42: too many spaces inside brackets

(brackets)

[error] 42-42: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 44-44: too many spaces inside brackets

(brackets)

[error] 44-44: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 51-51: too many spaces inside brackets

(brackets)

[error] 51-51: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 55-55: too many spaces inside brackets

(brackets)

[error] 55-55: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 57-57: too many spaces inside brackets

(brackets)

[error] 57-57: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 62-62: too many spaces inside brackets

(brackets)

[error] 62-62: too many spaces inside brackets

(brackets)

[error] 64-64: too many spaces inside brackets

(brackets)

[error] 64-64: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 67-67: too many spaces inside brackets

(brackets)

[error] 67-67: too many spaces inside brackets

(brackets)

[error] 68-68: too many spaces inside brackets

(brackets)

[error] 68-68: too many spaces inside brackets

(brackets)

[error] 70-70: too many spaces inside brackets

(brackets)

[error] 70-70: too many spaces inside brackets

(brackets)

[error] 71-71: too many spaces inside brackets

(brackets)

[error] 71-71: too many spaces inside brackets

(brackets)

[error] 72-72: too many spaces inside brackets

(brackets)

[error] 72-72: too many spaces inside brackets

(brackets)

73-76: Проверьте необходимость специальных ролей LOST PARADISE

Добавлены три специальные роли:

  • LPPBlueShieldOfficer
  • LPPAdjutant
  • LPPSecurityEngineer

Убедитесь, что:

  1. Эти роли необходимы для Halloween-тематической карты
  2. Их функционал не дублирует существующие роли
  3. Они правильно интегрируются с остальными системами
✅ Verification successful

Let me check the role definitions to better understand their purpose and integration.

Let me check if these roles are specifically tied to the Halloween/Hell maps or if they are general station roles.

Роли LOST PARADISE являются базовыми ролями станции

На основе проверки конфигурации и определений ролей можно сделать следующие выводы:

  • Эти роли не являются специфичными для Halloween-карт, а присутствуют на всех картах мода LOST PARADISE
  • Каждая роль имеет уникальный функционал:
    • LPPBlueShieldOfficer: офицер центрального командования с полным доступом и специальным снаряжением
    • LPPAdjutant: административная роль с широким доступом к различным отделам
    • LPPSecurityEngineer: специалист с комбинированным доступом к инженерным системам и безопасности

Роли правильно интегрированы в систему через:

  • Определенные требования к игровому времени
  • Уникальное снаряжение и доступы
  • Корректную департаментализацию
  • Систему имплантов и спецификаций
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Проверка определений ролей LOST PARADISE
echo "Поиск определений специальных ролей..."
rg -l "LPPBlueShieldOfficer|LPPAdjutant|LPPSecurityEngineer" --type yaml

Length of output: 2033

Script:

#!/bin/bash
# Check role definitions and their specific functionality
echo "Checking BlueShield Officer role definition..."
cat Resources/Prototypes/_LostParadise/Roles/Jobs/CentCom/blueshieldoficer.yml

echo -e "\nChecking Adjutant role definition..."
cat Resources/Prototypes/_LostParadise/Roles/Jobs/Command/adjutant.yml

echo -e "\nChecking Security Engineer role definition..."
cat Resources/Prototypes/_LostParadise/Roles/Jobs/Security/SecEng.yml

echo -e "\nChecking departments configuration..."
cat Resources/Prototypes/_LostParadise/Roles/Jobs/departments.yml

Length of output: 5592

Script:

#!/bin/bash
# Check if these roles are specifically configured for Halloween/Hell maps
echo "Checking Halloween/Hell specific configurations..."
rg -C 5 "LPPBlueShieldOfficer|LPPAdjutant|LPPSecurityEngineer" "Resources/Prototypes/_LostParadise/Maps/Hell/"

echo -e "\nChecking normal map configurations..."
rg -C 5 "LPPBlueShieldOfficer|LPPAdjutant|LPPSecurityEngineer" "Resources/Prototypes/_LostParadise/Maps/" --glob '!Hell/*'

Length of output: 9806

🧰 Tools
🪛 yamllint

[warning] 73-73: missing starting space in comment

(comments)

[error] 74-74: too many spaces inside brackets

(brackets)

[error] 74-74: too many spaces inside brackets

(brackets)

[error] 75-75: too many spaces inside brackets

(brackets)

[error] 75-75: too many spaces inside brackets

(brackets)

[error] 76-76: too many spaces inside brackets

(brackets)

[error] 76-76: too many spaces inside brackets

(brackets)

Resources/Prototypes/_LostParadise/Maps/Hell/H_asterisk.yml (1)

1-77: Хорошая реализация карты для Хэллоуина

Конфигурация карты хорошо структурирована и включает все необходимые компоненты:

  • Корректные настройки количества игроков
  • Полный набор должностей
  • Правильная интеграция с системой шаттлов
  • Подходящее размещение в директории Hell

После исправления проблем с переводами, карта будет готова к использованию.

🧰 Tools
🪛 yamllint

[warning] 25-25: missing starting space in comment

(comments)

[warning] 25-25: comment not indented like content

(comments-indentation)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 28-28: too many spaces inside brackets

(brackets)

[error] 29-29: too many spaces inside brackets

(brackets)

[error] 29-29: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 30-30: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 31-31: too many spaces inside brackets

(brackets)

[error] 32-32: too many spaces inside brackets

(brackets)

[error] 32-32: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 33-33: too many spaces inside brackets

(brackets)

[error] 34-34: too many spaces inside brackets

(brackets)

[error] 34-34: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 35-35: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[error] 36-36: too many spaces inside brackets

(brackets)

[warning] 37-37: missing starting space in comment

(comments)

[warning] 37-37: comment not indented like content

(comments-indentation)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 38-38: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[error] 39-39: too many spaces inside brackets

(brackets)

[warning] 39-39: too few spaces before comment

(comments)

[warning] 39-39: missing starting space in comment

(comments)

[error] 40-40: too many spaces inside brackets

(brackets)

[error] 40-40: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[error] 41-41: too many spaces inside brackets

(brackets)

[warning] 42-42: missing starting space in comment

(comments)

[warning] 42-42: comment not indented like content

(comments-indentation)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 43-43: too many spaces inside brackets

(brackets)

[error] 44-44: too many spaces inside brackets

(brackets)

[error] 44-44: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 45-45: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 46-46: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[error] 47-47: too many spaces inside brackets

(brackets)

[warning] 48-48: missing starting space in comment

(comments)

[warning] 48-48: comment not indented like content

(comments-indentation)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 49-49: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 50-50: too many spaces inside brackets

(brackets)

[error] 51-51: too many spaces inside brackets

(brackets)

[error] 51-51: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 52-52: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 53-53: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[error] 54-54: too many spaces inside brackets

(brackets)

[warning] 55-55: missing starting space in comment

(comments)

[warning] 55-55: comment not indented like content

(comments-indentation)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 56-56: too many spaces inside brackets

(brackets)

[error] 57-57: too many spaces inside brackets

(brackets)

[error] 57-57: too many spaces inside brackets

(brackets)

[error] 58-58: too many spaces inside brackets

(brackets)

[error] 58-58: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 59-59: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 60-60: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 61-61: too many spaces inside brackets

(brackets)

[error] 62-62: too many spaces inside brackets

(brackets)

[error] 62-62: too many spaces inside brackets

(brackets)

[warning] 62-62: too few spaces before comment

(comments)

[warning] 63-63: missing starting space in comment

(comments)

[warning] 63-63: comment not indented like content

(comments-indentation)

[error] 64-64: too many spaces inside brackets

(brackets)

[error] 64-64: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 65-65: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 66-66: too many spaces inside brackets

(brackets)

[error] 67-67: too many spaces inside brackets

(brackets)

[error] 67-67: too many spaces inside brackets

(brackets)

[warning] 68-68: missing starting space in comment

(comments)

[warning] 68-68: comment not indented like content

(comments-indentation)

[error] 69-69: too many spaces inside brackets

(brackets)

[error] 69-69: too many spaces inside brackets

(brackets)

[warning] 70-70: missing starting space in comment

(comments)

[warning] 70-70: comment not indented like content

(comments-indentation)

[error] 71-71: too many spaces inside brackets

(brackets)

[error] 71-71: too many spaces inside brackets

(brackets)

[error] 72-72: too many spaces inside brackets

(brackets)

[error] 72-72: too many spaces inside brackets

(brackets)

[error] 73-73: too many spaces inside brackets

(brackets)

[error] 73-73: too many spaces inside brackets

(brackets)

[warning] 74-74: missing starting space in comment

(comments)

[warning] 74-74: comment not indented like content

(comments-indentation)

[error] 75-75: too many spaces inside brackets

(brackets)

[error] 75-75: too many spaces inside brackets

(brackets)

[error] 76-76: too many spaces inside brackets

(brackets)

[error] 76-76: too many spaces inside brackets

(brackets)

[error] 77-77: too many spaces inside brackets

(brackets)

[error] 77-77: too many spaces inside brackets

(brackets)

Resources/Prototypes/_LostParadise/Maps/Hell/H_kerberos.yml (1)

15-16: Проверьте путь к шаттлу эвакуации

Убедитесь, что файл эвакуационного шаттла существует по указанному пути и соответствует тематике Хэллоуина.

✅ Verification successful

Путь к шаттлу эвакуации корректен и файл существует

Файл эвакуационного шаттла LPPKerberos_evac.yml найден по указанному пути и содержит корректную конфигурацию шаттла с названием "NT Evac Керберос". Файл содержит все необходимые компоненты для функционирования эвакуационного шаттла.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Проверка существования файла шаттла
fd "LPPKerberos_evac.yml" --type f

Length of output: 93

Script:

#!/bin/bash
# Проверим содержимое файла шаттла на предмет тематики Хэллоуина
cat Resources/Maps/_LostParadise/Shuttles/LPPKerberos_evac.yml

Length of output: 138547

Content.IntegrationTests/Tests/PostMapInitTest.cs (2)

70-73: Проверьте наличие прототипов карт

Убедитесь, что для всех новых карт (H_LPPKerberos, H_LPPAsterisk, H_LPPNormandy, H_LPPPebble) созданы соответствующие прототипы в конфигурационных файлах.

✅ Verification successful

Все прототипы карт корректно определены

Проверка показала, что:

  • Все 4 карты (H_LPPKerberos, H_LPPAsterisk, H_LPPNormandy, H_LPPPebble) имеют соответствующие прототипы в директории Resources/Prototypes/_LostParadise/Maps/Hell/
  • Карты правильно добавлены в пул карт LostParadiseMapPool.yml
  • Для каждой карты существует YAML-файл с определением в директории Resources/Maps/_LostParadise/Hell/
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Описание: Проверка наличия прототипов карт в конфигурационных файлах
rg -g "*.yml" "H_LPP(Kerberos|Asterisk|Normandy|Pebble)"

Length of output: 1808

70-73: Проверьте согласованность именования

Обратите внимание, что в массиве уже присутствуют обычные версии этих карт (LPPKerberos, LPPAsterisk и т.д.). Убедитесь, что новые карты действительно являются отдельными сущностями, а не заменой существующих.

✅ Verification successful

Карты H_LPP являются отдельными сущностями

Анализ показывает, что карты с префиксом H_LPP являются отдельными картами, расположенными в подкаталоге Hell:

  • Обычные карты (LPPKerberos, LPPAsterisk и т.д.) находятся в /Maps/_LostParadise/
  • Версии с префиксом H_ находятся в /Maps/_LostParadise/Hell/
  • У каждой карты свой уникальный идентификатор и отдельный файл конфигурации
  • H_LPP карты включены в отдельный пул карт (LostParadiseMapPool)

Именование согласовано и корректно, так как это действительно разные сущности, а не замена существующих карт.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Описание: Проверка уникальности идентификаторов карт
rg -g "*.yml" "map-id: (LPP|H_LPP)(Kerberos|Asterisk|Normandy|Pebble)"

Length of output: 72

Script:

#!/bin/bash
# Поиск всех упоминаний LPP карт в коде
rg "(LPPKerberos|LPPAsterisk|LPPNormandy|LPPPebble|H_LPPKerberos|H_LPPAsterisk|H_LPPNormandy|H_LPPPebble)" -A 2 -B 2

# Поиск определений карт в других форматах файлов
fd -e json -e xml -e config -e cs -x grep -l "(LPPKerberos|LPPAsterisk|LPPNormandy|LPPPebble|H_LPPKerberos|H_LPPAsterisk|H_LPPNormandy|H_LPPPebble)"

Length of output: 11949

Resources/Prototypes/_LostParadise/Maps/Hell/H_pebble.yml Show resolved Hide resolved
Resources/Prototypes/_LostParadise/Maps/Hell/H_normandy.yml Show resolved Hide resolved
Resources/Prototypes/_LostParadise/Maps/Hell/H_normandy.yml Show resolved Hide resolved
Resources/Prototypes/_LostParadise/Maps/Hell/H_asterisk.yml Show resolved Hide resolved
Resources/Prototypes/_LostParadise/Maps/Hell/H_asterisk.yml Show resolved Hide resolved
Resources/Prototypes/_LostParadise/Maps/Hell/H_kerberos.yml Show resolved Hide resolved
Resources/Prototypes/_LostParadise/Maps/Hell/H_kerberos.yml Show resolved Hide resolved
Resources/Prototypes/_LostParadise/Maps/Hell/H_kerberos.yml Show resolved Hide resolved
Resources/Prototypes/_LostParadise/Maps/Hell/H_kerberos.yml Show resolved Hide resolved
Content.IntegrationTests/Tests/PostMapInitTest.cs Show resolved Hide resolved
@Evgencheg Evgencheg merged commit 53f0114 into Lost-Paradise-Project:master Oct 28, 2024
11 checks passed
@BL02DL BL02DL deleted the helloween branch November 7, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@Evgencheg Evgencheg Awaiting requested review from Evgencheg Evgencheg is a code owner

Assignees
No one assigned
Labels
Изменения: C# Изменяет какие-либо файлы .cs Изменения: YML Изменяет какие-либо файлы .yml Приоритет: 1-Максимальный РЕШИТЬ НЕМЕДЛЕННО! Размер: 5-Микро Для очень очень маленьких ПР'ов/баг репортов Статус: Требуется одобрение Ожидание разработчиков для принятия решений
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BL02DL @Evgencheg