-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
greentea fix #298
greentea fix #298
Conversation
ПроцессВ данном пулл-реквесте внесены изменения в файл Изменения
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range comments (1)
Resources/Prototypes/Reagents/Consumable/Drink/drinks.yml (1)
Line range hint
279-293
: Необходимо добавить утоление жажды для холодного зеленого чаяДля согласованности с обычным зеленым чаем и другими холодными напитками, рекомендуется добавить эффект
SatiateThirst
дляIcedGreenTea
.Предлагаемые изменения:
id: IcedGreenTea name: reagent-name-iced-green-tea parent: BaseDrink desc: reagent-desc-iced-green-tea physicalDesc: reagent-physical-desc-aromatic flavor: icedtea color: "#5B821B" metamorphicSprite: sprite: Objects/Consumable/Drinks/glass_green.rsi state: icon_empty metamorphicMaxFillLevels: 5 metamorphicFillBaseName: fill- metamorphicChangeColor: false + metabolisms: + Drink: + effects: + - !type:SatiateThirst + factor: 3🧰 Tools
🪛 yamllint
[error] 111-111: wrong indentation: expected 8 but found 6
(indentation)
[error] 115-115: wrong indentation: expected 8 but found 6
(indentation)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
- Resources/Prototypes/Reagents/Consumable/Drink/drinks.yml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Resources/Prototypes/Reagents/Consumable/Drink/drinks.yml (1)
Pattern
**/*.yml
: так же в прототипах запрещены любые переводы на русский. Только на английском или ссылкой на перевод.Все добавляемые прототипы должны быть в нашей папке.
Никогда не предлагать ничего по отступам
При удалении дополнительного дополнения по типу
prob:
, можно оставить оригинальную часть с- id:
.
🪛 yamllint
Resources/Prototypes/Reagents/Consumable/Drink/drinks.yml
[error] 111-111: wrong indentation: expected 8 but found 6
(indentation)
🔇 Additional comments (1)
Resources/Prototypes/Reagents/Consumable/Drink/drinks.yml (1)
109-112
: Изменения соответствуют цели PR!Добавление эффекта
SatiateThirst
с фактором 3 для зеленого чая логично и соответствует другим напиткам в игре. Для сравнения:
- Обычный чай: фактор 2
- Вода: фактор 4
- Молоко: фактор 4
Значение фактора 3 является разумным балансом между обычным чаем и водой.
🧰 Tools
🪛 yamllint
[error] 111-111: wrong indentation: expected 8 but found 6
(indentation)
Описание обновления:
Медиа
Проверки
Изменения
🆑 Kest