Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halloween things #289

Merged
merged 7 commits into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
ent-LPPCandy = candy
.desc = This is my kingdom come, this is my kingdom come...
Comment on lines +1 to +2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Требуется исправить регистр текста и уникальность описания

Согласно правилам локализации, текст после = для сущностей, начинающихся с "ent-", должен начинаться с заглавной буквы. Также рекомендуется сделать описание более тематическим для Хэллоуина.

Примените следующие изменения:

-ent-LPPCandy = candy
+ent-LPPCandy = Candy

Committable suggestion was skipped due to low confidence.

ent-LPPCandy2 = { ent-LPPCandy }
.desc = { ent-LPPCandy.desc }
ent-LPPCandy3 = { ent-LPPCandy }
.desc = { ent-LPPCandy.desc }
ent-LPPCandy4 = { ent-LPPCandy }
.desc = { ent-LPPCandy.desc }
ent-LPPLolipop = lolipop
.desc = This is my kingdom come, this is my kingdom come...
Comment on lines +9 to +10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимы исправления в написании и уникальное описание

Обнаружены следующие проблемы:

  1. Неправильный регистр текста после =
  2. Опечатка в слове "lolipop"
  3. Описание полностью дублирует описание конфеты

Примените следующие изменения:

-ent-LPPLolipop = lolipop
-    .desc = This is my kingdom come, this is my kingdom come...
+ent-LPPLolipop = Lollipop
+    .desc = A sweet Halloween treat on a stick, perfect for trick-or-treating...
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPLolipop = lolipop
.desc = This is my kingdom come, this is my kingdom come...
ent-LPPLolipop = Lollipop
.desc = A sweet Halloween treat on a stick, perfect for trick-or-treating...

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
ent-HalloweenTree01 = dead tree
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо использовать заглавную букву после знака равенства

Согласно правилам кодирования, все переводы, начинающиеся с ent-, должны иметь текст с заглавной буквы после знака равенства.

Примените следующие изменения:

-ent-HalloweenTree01 = dead tree
+ent-HalloweenTree01 = Dead tree
-ent-HalloweenTree02 = dead tree
+ent-HalloweenTree02 = Dead tree
-ent-HalloweenTree03 = dead tree
+ent-HalloweenTree03 = Dead tree
-ent-HalloweenTree04 = dead tree
+ent-HalloweenTree04 = Dead tree

Also applies to: 3-3, 5-5, 7-7

.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree02 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree03 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree04 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
Comment on lines +1 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Оптимизация повторяющихся переводов

В файле присутствуют идентичные описания для всех деревьев. Согласно правилам кодирования, повторяющиеся переводы должны ссылаться на оригинальный перевод.

Рекомендуется реорганизовать код следующим образом:

 ent-HalloweenTree01 = Dead tree
     .desc = Dead tree with leaves on it, looks creepy.
-ent-HalloweenTree02 = dead tree
-    .desc = Dead tree with leaves on it, looks creepy.
-ent-HalloweenTree03 = dead tree
-    .desc = Dead tree with leaves on it, looks creepy.
-ent-HalloweenTree04 = dead tree
-    .desc = Dead tree with leaves on it, looks creepy.
+ent-HalloweenTree02 = { ent-HalloweenTree01 }
+    .desc = { ent-HalloweenTree01.desc }
+ent-HalloweenTree03 = { ent-HalloweenTree01 }
+    .desc = { ent-HalloweenTree01.desc }
+ent-HalloweenTree04 = { ent-HalloweenTree01 }
+    .desc = { ent-HalloweenTree01.desc }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-HalloweenTree01 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree02 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree03 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree04 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree01 = Dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree02 = { ent-HalloweenTree01 }
.desc = { ent-HalloweenTree01.desc }
ent-HalloweenTree03 = { ent-HalloweenTree01 }
.desc = { ent-HalloweenTree01.desc }
ent-HalloweenTree04 = { ent-HalloweenTree01 }
.desc = { ent-HalloweenTree01.desc }

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ent-LPPPSpiderDeco = spiders
.desc = Fake spiders that look like they're ready to bite you.
Comment on lines +1 to +2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо исправить регистр текста после знака равенства

Согласно правилам кодирования, все переводы, начинающиеся с 'ent-', должны иметь текст с большой буквы после знака равенства.

Примените следующие изменения:

-ent-LPPPSpiderDeco = spiders
+ent-LPPPSpiderDeco = Spiders
     .desc = Fake spiders that look like they're ready to bite you.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPPSpiderDeco = spiders
.desc = Fake spiders that look like they're ready to bite you.
ent-LPPPSpiderDeco = Spiders
.desc = Fake spiders that look like they're ready to bite you.

Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
ent-LPPPaperBagCandy = paper bag
.desc = A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
Comment on lines +1 to +2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо исправить регистр и описание для бумажного пакета

Согласно правилам кодирования, текст после '=' для записей, начинающихся с 'ent-', должен быть с заглавной буквы. Также описание не соответствует назначению предмета для сбора конфет на Хэллоуин.

Предлагаемые изменения:

-ent-LPPPaperBagCandy = paper bag
-    .desc = A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
+ent-LPPPaperBagCandy = Paper Bag
+    .desc = A paper bag for collecting Halloween candy and treats.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPPaperBagCandy = paper bag
.desc = A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
ent-LPPPaperBagCandy = Paper Bag
.desc = A paper bag for collecting Halloween candy and treats.

ent-LPPPumpkinBagCandy = pumpkin bag
.desc = A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
Comment on lines +3 to +4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо исправить регистр и описание для тыквенного пакета

Аналогичные проблемы с регистром и описанием, как в предыдущем случае.

Предлагаемые изменения:

-ent-LPPPumpkinBagCandy = pumpkin bag
-    .desc = A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
+ent-LPPPumpkinBagCandy = Pumpkin Bag
+    .desc = A festive pumpkin-shaped bag perfect for trick-or-treating.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPPumpkinBagCandy = pumpkin bag
.desc = A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
ent-LPPPumpkinBagCandy = Pumpkin Bag
.desc = A festive pumpkin-shaped bag perfect for trick-or-treating.

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
ent-LPPPosterHalloweenFamily = ghoast family
.desc = Picture of a family of ghosts, they look happy.
Comment on lines +1 to +2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Исправьте опечатку и используйте заглавную букву

В соответствии с правилами кодирования, текст после знака '=' должен начинаться с заглавной буквы для всех записей, начинающихся с 'ent-'. Также присутствует опечатка в слове "ghoast".

Примените следующие изменения:

-ent-LPPPosterHalloweenFamily = ghoast family
+ent-LPPPosterHalloweenFamily = Ghost Family
     .desc = Picture of a family of ghosts, they look happy.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPPosterHalloweenFamily = ghoast family
.desc = Picture of a family of ghosts, they look happy.
ent-LPPPosterHalloweenFamily = Ghost Family
.desc = Picture of a family of ghosts, they look happy.

ent-LPPPosterHalloweencounts = count's painting
.desc = Picture of some kind of vampire, the sight of him makes you feel cold.
Comment on lines +3 to +4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Используйте заглавную букву в начале

В соответствии с правилами кодирования, текст после знака '=' должен начинаться с заглавной буквы.

Примените следующие изменения:

-ent-LPPPosterHalloweencounts = count's painting
+ent-LPPPosterHalloweencounts = Count's Painting
     .desc = Picture of some kind of vampire, the sight of him makes you feel cold.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPPosterHalloweencounts = count's painting
.desc = Picture of some kind of vampire, the sight of him makes you feel cold.
ent-LPPPosterHalloweencounts = Count's Painting
.desc = Picture of some kind of vampire, the sight of him makes you feel cold.

ent-LPPPCheckboxes = checkboxes
.desc = Black and orange flags, it's got a halloween feel to it.
Comment on lines +5 to +6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Используйте заглавную букву в начале

В соответствии с правилами кодирования, текст после знака '=' должен начинаться с заглавной буквы.

Примените следующие изменения:

-ent-LPPPCheckboxes = checkboxes
+ent-LPPPCheckboxes = Checkboxes
     .desc = Black and orange flags, it's got a halloween feel to it.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPPCheckboxes = checkboxes
.desc = Black and orange flags, it's got a halloween feel to it.
ent-LPPPCheckboxes = Checkboxes
.desc = Black and orange flags, it's got a halloween feel to it.

ent-LPPPLightbulbs = light bulbs
.desc = Hanging garland, not the best source of light
Comment on lines +7 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Используйте заглавную букву в начале

В соответствии с правилами кодирования, текст после знака '=' должен начинаться с заглавной буквы.

Примените следующие изменения:

-ent-LPPPLightbulbs = light bulbs
+ent-LPPPLightbulbs = Light Bulbs
     .desc = Hanging garland, not the best source of light
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPPLightbulbs = light bulbs
.desc = Hanging garland, not the best source of light
ent-LPPPLightbulbs = Light Bulbs
.desc = Hanging garland, not the best source of light

2 changes: 2 additions & 0 deletions Resources/Locale/ru-RU/_LostParadise/halloween.ftl
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

⚠️ Potential issue

Отсутствуют необходимые локализации

Файл пуст, но должен содержать переводы для новых сущностей, связанных с Хэллоуином. Необходимо добавить следующие локализации:

  1. Конфеты:
ent-LPPCandy = Конфета
    .desc = Обычная конфета, состоящая из сахара и других вещей.
ent-LPPCandy2 = { ent-LPPCandy }
    .desc = { ent-LPPCandy.desc }
ent-LPPCandy3 = { ent-LPPCandy }
    .desc = { ent-LPPCandy.desc }
ent-LPPCandy4 = { ent-LPPCandy }
    .desc = { ent-LPPCandy.desc }
ent-LPPLolipop = Конфета на палочке
    .desc = Всё такая же конфета, но на палочке.
  1. Декорации:
ent-HalloweenTree01 = Мёртвое дерево
    .desc = Мёртвое дерево с остатками листьев на нём, выглядит жутко.
ent-HalloweenTree02 = { ent-HalloweenTree01 }
    .desc = { ent-HalloweenTree01.desc }
ent-HalloweenTree03 = { ent-HalloweenTree01 }
    .desc = { ent-HalloweenTree01.desc }
ent-HalloweenTree04 = { ent-HalloweenTree01 }
    .desc = { ent-HalloweenTree01.desc }

ent-LPPPSpiderDeco = Паучки
    .desc = Муляжи паучков, которые выглядят так, будто готовы вас покусать.

ent-LPPPaperBagCandy = Бумажный пакет
    .desc = Пакет из бумаги, украшен в тематике Хэллоуина.

ent-LPPPumpkinBagCandy = Корзинка из тыквы
    .desc = Корзинка, вырезанная из тыквы с приделанной ручкой.
  1. Постеры и украшения:
ent-LPPPosterHalloweenFamily = Призрачная семья
    .desc = Картина семьи призраков, они выглядят счастливыми.

ent-LPPPosterHalloweencounts = Картина графа
    .desc = Картина с каким-то вампиром, от его взгляда вам становится холодно.

ent-LPPPCheckboxes = Флажки
    .desc = Чёрно-оранжевые флажки, навевают чувством Хэллоуина.

ent-LPPPLightbulbs = Гирлянда
    .desc = Подвесная гирлянда, не самый лучший источник освещения.

Пожалуйста, убедитесь, что:

  1. Все переводы, начинающиеся с "ent-", имеют заглавную букву после знака "=".
  2. Повторяющиеся переводы используют структуру с ссылками на базовый перевод.
  3. Все описания грамматически корректны и не содержат орфографических ошибок.

Хотите, чтобы я создал GitHub issue для отслеживания добавления этих локализаций?

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
ent-LPPCandy = candy
.desc = This is my kingdom come, this is my kingdom come...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Требуется перевод и исправление регистра

Согласно правилам локализации:

  1. Значение должно быть на русском языке
  2. После "=" должна быть заглавная буква для сущностей, начинающихся с "ent-"
  3. Описание также должно быть переведено на русский язык

Примените следующие изменения:

-ent-LPPCandy = candy
-    .desc = This is my kingdom come, this is my kingdom come...
+ent-LPPCandy = Конфета
+    .desc = Моё сладкое королевство, моё сладкое королевство...
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPCandy = candy
.desc = This is my kingdom come, this is my kingdom come...
ent-LPPCandy = Конфета
.desc = Моё сладкое королевство, моё сладкое королевство...

ent-LPPCandy2 = { ent-LPPCandy }
.desc = { ent-LPPCandy.desc }
ent-LPPCandy3 = { ent-LPPCandy }
.desc = { ent-LPPCandy.desc }
ent-LPPCandy4 = { ent-LPPCandy }
.desc = { ent-LPPCandy.desc }
ent-LPPLolipop = lolipop
.desc = This is my kingdom come, this is my kingdom come...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Исправьте опечатку и добавьте перевод

В оригинале есть опечатка "lolipop" (правильно "lollipop"). Также требуется перевод на русский язык и использование заглавной буквы после "=".

Примените следующие изменения:

-ent-LPPLolipop = lolipop
-    .desc = This is my kingdom come, this is my kingdom come...
+ent-LPPLolipop = Леденец
+    .desc = Моё сладкое королевство, моё сладкое королевство...
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPLolipop = lolipop
.desc = This is my kingdom come, this is my kingdom come...
ent-LPPLolipop = Леденец
.desc = Моё сладкое королевство, моё сладкое королевство...

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
ent-HalloweenTree01 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree02 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree03 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree04 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо исправить регистр текста после знака "="

Согласно правилам кодирования, все переводы, начинающиеся с "ent-", должны иметь текст с заглавной буквы после знака "=".

Примените следующие изменения:

-ent-HalloweenTree01 = dead tree
+ent-HalloweenTree01 = Dead tree
    .desc = Dead tree with leaves on it, looks creepy.
-ent-HalloweenTree02 = dead tree
+ent-HalloweenTree02 = Dead tree
    .desc = Dead tree with leaves on it, looks creepy.
-ent-HalloweenTree03 = dead tree
+ent-HalloweenTree03 = Dead tree
    .desc = Dead tree with leaves on it, looks creepy.
-ent-HalloweenTree04 = dead tree
+ent-HalloweenTree04 = Dead tree
    .desc = Dead tree with leaves on it, looks creepy.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-HalloweenTree01 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree02 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree03 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree04 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree01 = Dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree02 = Dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree03 = Dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree04 = Dead tree
.desc = Dead tree with leaves on it, looks creepy.

🛠️ Refactor suggestion

Оптимизация повторяющегося контента

Рекомендуется использовать механизм ссылок FTL для оптимизации повторяющегося контента.

Предлагаемая оптимизация:

-ent-HalloweenTree01 = dead tree
-    .desc = Dead tree with leaves on it, looks creepy.
-ent-HalloweenTree02 = dead tree
-    .desc = Dead tree with leaves on it, looks creepy.
-ent-HalloweenTree03 = dead tree
-    .desc = Dead tree with leaves on it, looks creepy.
-ent-HalloweenTree04 = dead tree
-    .desc = Dead tree with leaves on it, looks creepy.
+ent-HalloweenTree01 = Dead tree
+    .desc = Dead tree with leaves on it, looks creepy.
+ent-HalloweenTree02 = { ent-HalloweenTree01 }
+    .desc = { ent-HalloweenTree01.desc }
+ent-HalloweenTree03 = { ent-HalloweenTree01 }
+    .desc = { ent-HalloweenTree01.desc }
+ent-HalloweenTree04 = { ent-HalloweenTree01 }
+    .desc = { ent-HalloweenTree01.desc }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-HalloweenTree01 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree02 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree03 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree04 = dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree01 = Dead tree
.desc = Dead tree with leaves on it, looks creepy.
ent-HalloweenTree02 = { ent-HalloweenTree01 }
.desc = { ent-HalloweenTree01.desc }
ent-HalloweenTree03 = { ent-HalloweenTree01 }
.desc = { ent-HalloweenTree01.desc }
ent-HalloweenTree04 = { ent-HalloweenTree01 }
.desc = { ent-HalloweenTree01.desc }

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ent-LPPPSpiderDeco = spiders
.desc = Fake spiders that look like they're ready to bite you.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо исправить форматирование и добавить русский перевод

Текст после знака '=' должен быть с заглавной буквы для всех идентификаторов, начинающихся с 'ent-'. Также необходимо использовать русский перевод вместо английского текста.

Предлагаемые изменения:

-ent-LPPPSpiderDeco = spiders
-    .desc = Fake spiders that look like they're ready to bite you.
+ent-LPPPSpiderDeco = Пауки
+    .desc = Искусственные пауки, которые выглядят так, будто готовы вас укусить.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPPSpiderDeco = spiders
.desc = Fake spiders that look like they're ready to bite you.
ent-LPPPSpiderDeco = Пауки
.desc = Искусственные пауки, которые выглядят так, будто готовы вас укусить.

Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
ent-LPPPaperBagCandy = paper bag
.desc = A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Исправьте форматирование и добавьте перевод на русский язык

Согласно правилам кодирования:

  1. После "=" должна быть заглавная буква для ключей, начинающихся с "ent-"
  2. Текст должен быть на русском языке

Предлагаемые изменения:

-ent-LPPPaperBagCandy = paper bag
-    .desc = A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
+ent-LPPPaperBagCandy = Бумажный пакет
+    .desc = Пакет для хранения химических продуктов, таких как таблетки, контейнеры для таблеток, бутылки и шприцы.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPPaperBagCandy = paper bag
.desc = A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
ent-LPPPaperBagCandy = Бумажный пакет
.desc = Пакет для хранения химических продуктов, таких как таблетки, контейнеры для таблеток, бутылки и шприцы.

ent-LPPPumpkinBagCandy = pumpkin bag
.desc = A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Используйте ссылку на существующий перевод и добавьте перевод на русский язык

Поскольку описание идентично первому элементу, следует использовать ссылку на существующий перевод:

-ent-LPPPumpkinBagCandy = pumpkin bag
-    .desc = A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
+ent-LPPPumpkinBagCandy = Тыквенный пакет
+    .desc = { ent-LPPPaperBagCandy.desc }

Committable suggestion was skipped due to low confidence.

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
ent-LPPPosterHalloweenFamily = ghoast family
.desc = Picture of a family of ghosts, they look happy.
ent-LPPPosterHalloweencounts = count's painting
.desc = Picture of some kind of vampire, the sight of him makes you feel cold.
ent-LPPPCheckboxes = checkboxes
.desc = Black and orange flags, it's got a halloween feel to it.
ent-LPPPLightbulbs = light bulbs
.desc = Hanging garland, not the best source of light
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо перевести контент на русский язык и исправить форматирование

Обнаружены следующие проблемы:

  1. Весь контент на английском языке вместо русского
  2. Все переводы, начинающиеся с "ent-", должны начинаться с заглавной буквы после знака "="
  3. В слове "ghoast" допущена опечатка
  4. Несогласованное использование точек в конце описаний

Предлагаемые исправления:

-ent-LPPPosterHalloweenFamily = ghoast family
-    .desc = Picture of a family of ghosts, they look happy.
+ent-LPPPosterHalloweenFamily = Семейство призраков
+    .desc = Картина с изображением семьи призраков, выглядят счастливыми.

-ent-LPPPosterHalloweencounts = count's painting
-    .desc = Picture of some kind of vampire, the sight of him makes you feel cold.
+ent-LPPPosterHalloweencounts = Портрет графа
+    .desc = Картина с изображением какого-то вампира, от его взгляда становится холодно.

-ent-LPPPCheckboxes = checkboxes
-    .desc = Black and orange flags, it's got a halloween feel to it.
+ent-LPPPCheckboxes = Флажки
+    .desc = Чёрно-оранжевые флажки в стиле Хэллоуина.

-ent-LPPPLightbulbs = light bulbs
-    .desc = Hanging garland, not the best source of light
+ent-LPPPLightbulbs = Лампочки
+    .desc = Висящая гирлянда, не самый лучший источник света.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ent-LPPPosterHalloweenFamily = ghoast family
.desc = Picture of a family of ghosts, they look happy.
ent-LPPPosterHalloweencounts = count's painting
.desc = Picture of some kind of vampire, the sight of him makes you feel cold.
ent-LPPPCheckboxes = checkboxes
.desc = Black and orange flags, it's got a halloween feel to it.
ent-LPPPLightbulbs = light bulbs
.desc = Hanging garland, not the best source of light
ent-LPPPosterHalloweenFamily = Семейство призраков
.desc = Картина с изображением семьи призраков, выглядят счастливыми.
ent-LPPPosterHalloweencounts = Портрет графа
.desc = Картина с изображением какого-то вампира, от его взгляда становится холодно.
ent-LPPPCheckboxes = Флажки
.desc = Чёрно-оранжевые флажки в стиле Хэллоуина.
ent-LPPPLightbulbs = Лампочки
.desc = Висящая гирлянда, не самый лучший источник света.

Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
- type: entity
name: candy
parent: FoodBase
id: LPPCandy
description: This is my kingdom come, this is my kingdom come...
components:
- type: Sprite
sprite: _LostParadise/Objects/Consumable/halloween.rsi
state: candy_1
- type: Item
size: Tiny
shape:
- 0, 0, 0, 0
- type: SolutionContainerManager
solutions:
food:
maxVol: 5
reagents:
- ReagentId: Sugar
Quantity: 3
- ReagentId: Nutriment
Quantity: 1
- ReagentId: Theobromine
Quantity: 1
- type: Tag
tags:
- LPPCandy
Comment on lines +1 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

⚠️ Potential issue

Необходимо изменить описание и исправить отступы

  1. Описание должно быть на английском языке согласно руководству по кодированию. Пожалуйста, замените текст описания на соответствующий английский вариант.

  2. Обратите внимание на отступы в файле. Они должны быть согласованы. Исправьте следующие строки:

    • Строка 7: увеличьте отступ минимум до 3 пробелов
    • Строка 13: увеличьте отступ минимум до 5 пробелов
    • Строка 19: увеличьте отступ до 10 пробелов

Предлагаемые изменения для описания:

- description: This is my kingdom come, this is my kingdom come...
+ description: A sweet treat perfect for Halloween.

Committable suggestion was skipped due to low confidence.

🧰 Tools
🪛 yamllint

[error] 7-7: wrong indentation: expected at least 3

(indentation)


[error] 13-13: wrong indentation: expected at least 5

(indentation)


[error] 19-19: wrong indentation: expected 10 but found 8

(indentation)


- type: entity
parent: LPPCandy
id: LPPCandy2
components:
- type: Sprite
state: candy_2
Comment on lines +29 to +34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Исправьте отступ в компоненте Sprite

Отступ в строке 33 должен быть увеличен до 4 пробелов для соответствия стилю остального кода.

🧰 Tools
🪛 yamllint

[error] 33-33: wrong indentation: expected 4 but found 2

(indentation)


- type: entity
parent: LPPCandy
id: LPPCandy3
components:
- type: Sprite
state: candy_3
Comment on lines +36 to +41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Исправьте отступ в компоненте Sprite

Отступ в строке 40 должен быть увеличен до 4 пробелов для соответствия стилю остального кода.

🧰 Tools
🪛 yamllint

[error] 40-40: wrong indentation: expected 4 but found 2

(indentation)


- type: entity
parent: LPPCandy
id: LPPCandy4
components:
- type: Sprite
state: candy_4
Comment on lines +43 to +48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Исправьте отступ в компоненте Sprite

Отступ в строке 47 должен быть увеличен до 4 пробелов для соответствия стилю остального кода.

🧰 Tools
🪛 yamllint

[error] 47-47: wrong indentation: expected 4 but found 2

(indentation)


- type: entity
name: lolipop
parent: LPPCandy
id: LPPLolipop
description: This is my kingdom come, this is my kingdom come...
components:
- type: Sprite
state: lollipop
- type: Item
size: Tiny
shape:
- 0, 0, 0, 1
- type: SolutionContainerManager
solutions:
food:
maxVol: 15
reagents:
- ReagentId: Sugar
Quantity: 8
- ReagentId: Nutriment
Quantity: 4
- ReagentId: Theobromine
Quantity: 3
- type: Tag
tags:
- LPPCandy
Comment on lines +50 to +75
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

⚠️ Potential issue

Необходимо обновить описание, исправить отступы и добавить новую строку в конце файла

  1. Описание для LPPLolipop идентично описанию LPPCandy. Пожалуйста, создайте уникальное описание для леденца, чтобы лучше отличать его от обычной конфеты.

  2. Исправьте следующие отступы:

    • Строка 56: увеличьте отступ до 4 пробелов
    • Строка 61: увеличьте отступ до 6 пробелов
    • Строка 67: увеличьте отступ до 10 пробелов
  3. Добавьте пустую строку в конце файла.

Предлагаемые изменения для описания:

- description: This is my kingdom come, this is my kingdom come...
+ description: A colorful lollipop, perfect for trick-or-treating.

Committable suggestion was skipped due to low confidence.

🧰 Tools
🪛 yamllint

[error] 56-56: wrong indentation: expected 4 but found 2

(indentation)


[error] 61-61: wrong indentation: expected 6 but found 4

(indentation)


[error] 67-67: wrong indentation: expected 10 but found 8

(indentation)


[error] 75-75: no new line character at the end of file

(new-line-at-end-of-file)

Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
- type: entity
parent: BaseTree
id: HalloweenTree01
name: dead tree
description: Dead tree with leaves on it, looks creepy.
components:
- type: Sprite
sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
state: halloweentree01
Comment on lines +1 to +9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Определение сущности корректно, но есть проблема с отступами.

Определение сущности HalloweenTree01 выглядит правильным и соответствует теме Хэллоуина. Спрайт корректно размещен в папке _LostParadise.

Однако, есть проблема с отступами в компоненте Sprite. Исправьте отступ следующим образом:

  components:
-  - type: Sprite
+    - type: Sprite
      sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
      state: halloweentree01

Committable suggestion was skipped due to low confidence.

🧰 Tools
🪛 yamllint

[error] 7-7: wrong indentation: expected at least 3

(indentation)


- type: entity
parent: BaseTree
id: HalloweenTree02
name: dead tree
description: Dead tree with leaves on it, looks creepy.
components:
- type: Sprite
sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
state: halloweentree02
Comment on lines +11 to +19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Определение сущности корректно, но присутствует та же проблема с отступами.

Определение сущности HalloweenTree02 соответствует структуре предыдущего дерева и теме Хэллоуина.

Исправьте отступ в компоненте Sprite аналогично предыдущему комментарию:

  components:
-  - type: Sprite
+    - type: Sprite
      sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
      state: halloweentree02
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- type: entity
parent: BaseTree
id: HalloweenTree02
name: dead tree
description: Dead tree with leaves on it, looks creepy.
components:
- type: Sprite
sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
state: halloweentree02
- type: entity
parent: BaseTree
id: HalloweenTree02
name: dead tree
description: Dead tree with leaves on it, looks creepy.
components:
- type: Sprite
sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
state: halloweentree02
🧰 Tools
🪛 yamllint

[error] 17-17: wrong indentation: expected at least 3

(indentation)


- type: entity
parent: BaseTree
id: HalloweenTree03
name: dead tree
description: Dead tree with leaves on it, looks creepy.
components:
- type: Sprite
sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
state: halloweentree03
Comment on lines +21 to +29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Определение сущности корректно, но сохраняется проблема с отступами.

Определение сущности HalloweenTree03 соответствует структуре предыдущих деревьев и теме Хэллоуина.

Пожалуйста, исправьте отступ в компоненте Sprite:

  components:
-  - type: Sprite
+    - type: Sprite
      sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
      state: halloweentree03
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- type: entity
parent: BaseTree
id: HalloweenTree03
name: dead tree
description: Dead tree with leaves on it, looks creepy.
components:
- type: Sprite
sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
state: halloweentree03
- type: entity
parent: BaseTree
id: HalloweenTree03
name: dead tree
description: Dead tree with leaves on it, looks creepy.
components:
- type: Sprite
sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
state: halloweentree03
🧰 Tools
🪛 yamllint

[error] 27-27: wrong indentation: expected at least 3

(indentation)


- type: entity
parent: BaseTree
id: HalloweenTree04
name: dead tree
description: Dead tree with leaves on it, looks creepy.
components:
- type: Sprite
sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
state: halloweentree04

Comment on lines +1 to +40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Общий обзор файла

Файл содержит корректные определения четырех сущностей деревьев для Хэллоуина. Все сущности правильно размещены в папке _LostParadise, и в файле отсутствуют русские переводы, что соответствует указанным рекомендациям.

Однако, есть несколько проблем с форматированием:

  1. Во всех четырех определениях сущностей присутствует одинаковая проблема с отступами в компоненте Sprite.
  2. В конце файла есть лишняя пустая строка.

Рекомендуется исправить эти проблемы форматирования. Вот команда sed, которая может автоматически исправить отступы во всем файле:

sed -i 's/^  - type: Sprite/    - type: Sprite/' Resources/Prototypes/_LostParadise/Entities/Objects/Decoration/Flora/halloween.yml

Также не забудьте удалить лишнюю пустую строку в конце файла.

🧰 Tools
🪛 yamllint

[error] 7-7: wrong indentation: expected at least 3

(indentation)


[error] 17-17: wrong indentation: expected at least 3

(indentation)


[error] 27-27: wrong indentation: expected at least 3

(indentation)


[error] 37-37: wrong indentation: expected at least 3

(indentation)


[error] 40-40: too many blank lines

(1 > 0) (empty-lines)

Comment on lines +31 to +40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Определение сущности корректно, но есть проблемы с форматированием.

Определение сущности HalloweenTree04 соответствует структуре предыдущих деревьев и теме Хэллоуина.

Пожалуйста, внесите следующие изменения:

  1. Исправьте отступ в компоненте Sprite:
  components:
-  - type: Sprite
+    - type: Sprite
      sprite: _LostParadise/Objects/Decoration/Flora/flora_halloween.rsi
      state: halloweentree04
  1. Удалите лишнюю пустую строку в конце файла.

Committable suggestion was skipped due to low confidence.

🧰 Tools
🪛 yamllint

[error] 37-37: wrong indentation: expected at least 3

(indentation)


[error] 40-40: too many blank lines

(1 > 0) (empty-lines)

Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
- type: entity
parent: BaseSign
id: LPPPSpiderDeco
name: spiders
description: Fake spiders that look like they're ready to bite you.
components:
- type: Sprite
sprite: _LostParadise/Objects/Decoration/halloween.rsi
snapCardinals: true
layers:
- state: spider_big
map: [ "enum.DamageStateVisualLayers.Base" ]
Comment on lines +7 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Компонент Sprite определен корректно.

Путь к спрайту и определение слоя соответствуют требованиям. Используется правильная папка _LostParadise.

Однако, обратите внимание на лишние пробелы внутри квадратных скобок в строке 12:

      map: [ "enum.DamageStateVisualLayers.Base" ]

Рекомендуется удалить лишние пробелы:

      map: ["enum.DamageStateVisualLayers.Base"]
🧰 Tools
🪛 yamllint

[error] 7-7: wrong indentation: expected at least 3

(indentation)


[error] 11-11: wrong indentation: expected at least 5

(indentation)


[error] 12-12: too many spaces inside brackets

(brackets)


[error] 12-12: too many spaces inside brackets

(brackets)

- type: InteractionOutline
- type: RandomSprite
available:
- enum.DamageStateVisualLayers.Base:
spider_big: ""
spider_big2: ""
spider_mini1: ""
spider_mini2: ""
spider_mini3: ""
- type: Damageable
damageContainer: Inorganic
- type: Destructible
thresholds:
- trigger:
!type:DamageTrigger
damage: 10
behaviors:
- !type:PlaySoundBehavior
sound:
collection: WoodDestroyHeavy
- !type:DoActsBehavior
acts: [ "Destruction" ]
Comment on lines +24 to +34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Компонент Destructible реализован корректно, но есть предложения по улучшению.

Компонент Destructible хорошо определен и подходит для разрушаемого декоративного объекта. Однако есть два момента, на которые стоит обратить внимание:

  1. Использование звуковой коллекции WoodDestroyHeavy может не соответствовать тематике паучьих украшений. Рекомендуется рассмотреть возможность использования более подходящего звука, например, чего-то связанного с пластиком или тканью.

  2. В строке 34 есть лишние пробелы внутри квадратных скобок:

        acts: [ "Destruction" ]

Рекомендуется исправить на:

        acts: ["Destruction"]
🧰 Tools
🪛 yamllint

[error] 26-26: wrong indentation: expected 6 but found 4

(indentation)


[error] 30-30: wrong indentation: expected 8 but found 6

(indentation)


[error] 34-34: too many spaces inside brackets

(brackets)


[error] 34-34: too many spaces inside brackets

(brackets)


[error] 34-34: no new line character at the end of file

(new-line-at-end-of-file)

Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
- type: entity
name: paper bag
id: LPPPaperBagCandy
parent: CandyBucket
description: A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
components:
- type: Sprite
sprite: _LostParadise/Objects/Specific/halloween/paper_bag.rsi
layers:
- state: empty_icon
map: [ "enum.ToggleVisuals.Layer" ]
- type: Storage
grid:
- 0,0,4,2
whitelist:
tags:
- LPPCandy
Comment on lines +1 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

⚠️ Potential issue

Необходимо внести изменения в определение сущности "paper bag"

  1. Измените описание на более подходящее теме Хэллоуина, например: "Бумажный пакет для сбора конфет на Хэллоуин."

  2. Добавьте перевод имени на русский язык:

    name:
      en-US: paper bag
      ru-RU: бумажный пакет
  3. Проверьте и исправьте путь к спрайту:

    sprite: _LostParadise/Objects/Specific/halloween/paper_bag.rsi
  4. Исправьте отступы в следующих строках:

    • Строка 10: увеличьте отступ до 8 пробелов
    • Строка 14: увеличьте отступ до 8 пробелов
  5. Уберите лишние пробелы внутри квадратных скобок в строке 11.

🧰 Tools
🪛 yamllint

[error] 10-10: wrong indentation: expected 8 but found 6

(indentation)


[error] 11-11: too many spaces inside brackets

(brackets)


[error] 11-11: too many spaces inside brackets

(brackets)


[error] 14-14: wrong indentation: expected 8 but found 6

(indentation)


- type: entity
name: pumpkin bag
id: LPPPumpkinBagCandy
parent: CandyBucket
description: A bag for storing chemistry products, such as pills, pill canisters, bottles, and syringes.
components:
- type: Sprite
sprite: _LostParadise/Objects/Specific/halloween/pumpkin_bag.rsi
layers:
- state: empty_icon
map: [ "enum.ToggleVisuals.Layer" ]
- type: Storage
grid:
- 0,0,4,2
whitelist:
tags:
- LPPCandy
Comment on lines +19 to +35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

⚠️ Potential issue

Необходимо внести изменения в определение сущности "pumpkin bag" и исправить форматирование файла

  1. Измените описание на более подходящее теме Хэллоуина, например: "Тыквенная сумка для сбора конфет на Хэллоуин."

  2. Добавьте перевод имени на русский язык:

    name:
      en-US: pumpkin bag
      ru-RU: тыквенная сумка
  3. Исправьте отступы в следующих строках:

    • Строка 28: увеличьте отступ до 8 пробелов
    • Строка 32: увеличьте отступ до 8 пробелов
  4. Уберите лишние пробелы внутри квадратных скобок в строке 29.

  5. Добавьте пустую строку в конец файла для соответствия стандартам форматирования YAML.

🧰 Tools
🪛 yamllint

[error] 28-28: wrong indentation: expected 8 but found 6

(indentation)


[error] 29-29: too many spaces inside brackets

(brackets)


[error] 29-29: too many spaces inside brackets

(brackets)


[error] 32-32: wrong indentation: expected 8 but found 6

(indentation)


[error] 35-35: no new line character at the end of file

(new-line-at-end-of-file)

Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
- type: entity
parent: LPPPosterBase
id: LPPPosterHalloweenFamily
name: ghoast family
description: Picture of a family of ghosts, they look happy.
components:
- type: Sprite
sprite: _LostParadise/Structures/Wallmounts/halloween.rsi
state: picture_family
noRot: true

- type: entity
parent: LPPPosterBase
id: LPPPosterHalloweencounts
name: count's painting
description: Picture of some kind of vampire, the sight of him makes you feel cold.
components:
- type: Sprite
sprite: _LostParadise/Structures/Wallmounts/halloween.rsi
state: сounts_painting
noRot: true
Comment on lines +12 to +21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Исправьте опечатку в имени состояния спрайта.

Определение сущности LPPPosterHalloweencounts в целом корректно, но есть потенциальная опечатка в имени состояния спрайта.

Пожалуйста, примените следующее исправление:

- state: сounts_painting
+ state: counts_painting

Это заменит кириллическую 'с' на латинскую 'c' в имени состояния спрайта, что предотвратит возможные проблемы при обращении к спрайту.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- type: entity
parent: LPPPosterBase
id: LPPPosterHalloweencounts
name: count's painting
description: Picture of some kind of vampire, the sight of him makes you feel cold.
components:
- type: Sprite
sprite: _LostParadise/Structures/Wallmounts/halloween.rsi
state: сounts_painting
noRot: true
- type: entity
parent: LPPPosterBase
id: LPPPosterHalloweencounts
name: count's painting
description: Picture of some kind of vampire, the sight of him makes you feel cold.
components:
- type: Sprite
sprite: _LostParadise/Structures/Wallmounts/halloween.rsi
state: counts_painting
noRot: true
🧰 Tools
🪛 yamllint

[error] 18-18: wrong indentation: expected at least 3

(indentation)


- type: entity
parent: BaseSign
id: LPPPCheckboxes
name: checkboxes
description: Black and orange flags, it's got a halloween feel to it.
components:
- type: Sprite
sprite: _LostParadise/Structures/Wallmounts/halloween.rsi
state: checkboxes
noRot: true
Comment on lines +23 to +32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Удалите лишний пробел в конце описания.

Определение сущности LPPPCheckboxes корректно, но есть незначительная проблема с форматированием.

Пожалуйста, примените следующее исправление:

- description: Black and orange flags, it's got a halloween feel to it. 
+ description: Black and orange flags, it's got a halloween feel to it.

Это удалит лишний пробел в конце строки описания, что улучшит форматирование файла.

Committable suggestion was skipped due to low confidence.

🧰 Tools
🪛 yamllint

[error] 27-27: trailing spaces

(trailing-spaces)


[error] 29-29: wrong indentation: expected at least 3

(indentation)


- type: entity
parent: BaseSign
id: LPPPLightbulbs
name: light bulbs
description: Hanging garland, not the best source of light
components:
- type: PointLight
radius: 2.0
energy: 2.5
color: "#e8b964"
- type: Sprite
sprite: _LostParadise/Structures/Wallmounts/halloween.rsi
state: light_bulbs
noRot: true
4 changes: 4 additions & 0 deletions Resources/Prototypes/_LostParadise/tags.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,7 @@

- type: Tag
id: LPPProcessedDiamond

- type: Tag
id: LPPCandy #Halloween

Comment on lines +167 to +169
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Исправьте форматирование нового тега

Новый тег LPPCandy добавлен корректно, но есть несколько моментов, требующих внимания:

  1. Добавьте пробел после символа # в комментарии.
  2. Удалите лишнюю пустую строку после определения тега.

Предлагаемые изменения:

 - type: Tag
-  id: LPPCandy #Halloween
+  id: LPPCandy # Halloween
-
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- type: Tag
id: LPPCandy #Halloween
- type: Tag
id: LPPCandy # Halloween
🧰 Tools
🪛 yamllint

[warning] 168-168: too few spaces before comment

(comments)


[warning] 168-168: missing starting space in comment

(comments)


[error] 169-169: too many blank lines

(1 > 0) (empty-lines)

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/e00cae8d065f9cf520688cc0dd0e15ba5bef12a9",
Comment on lines +1 to +4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Метаданные корректны, но можно улучшить.

Информация о версии, лицензии и авторских правах указана правильно. Хорошо, что вы включили ссылку на конкретный коммит.

Рекомендую добавить дату коммита для облегчения отслеживания изменений в будущем. Например:

-    "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/e00cae8d065f9cf520688cc0dd0e15ba5bef12a9",
+    "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/e00cae8d065f9cf520688cc0dd0e15ba5bef12a9 (Date: YYYY-MM-DD)",

Committable suggestion was skipped due to low confidence.

"size": {
"x": 32,
"y": 32
},
"states": [
{
"name": "candy_1"
},
{
"name": "candy_2"
},
{
"name": "candy_3"
},
{
"name": "candy_4"
},
{
"name": "lollipop"
}
]
Comment on lines +9 to +25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Состояния определены корректно, но можно улучшить описание.

Пять различных состояний для конфет обеспечивают хорошее разнообразие. Названия понятны и последовательны.

Для улучшения ясности рекомендую добавить краткие описания для каждого типа конфет. Например:

 {
     "name": "candy_1"
+    "description": "Круглая конфета в красной обертке"
 },
 {
     "name": "candy_2"
+    "description": "Овальная конфета в синей обертке"
 },

Это поможет разработчикам и дизайнерам лучше понимать визуальные различия между типами конфет.

Committable suggestion was skipped due to low confidence.

}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/e00cae8d065f9cf520688cc0dd0e15ba5bef12a9",
Comment on lines +1 to +4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Информация о версии и лицензии корректна.

Версия, лицензия и информация об авторских правах указаны правильно. Хорошая практика включать ссылку на исходный репозиторий и хеш коммита.

Рекомендуется добавить дату коммита для облегчения отслеживания изменений в будущем.

"size": {
"x": 64,
"y": 64
},
"states": [
{
"name": "icon"
},
{
"name": "halloweentree01"
},
{
"name": "halloweentree02"
},
{
"name": "halloweentree03"
},
{
"name": "halloweentree04"
}
]
Comment on lines +9 to +25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Состояния текстуры определены корректно.

Пять состояний (включая "icon" и четыре варианта хэллоуинских деревьев) определены правильно. Структура JSON и именование состояний соответствуют стандартам.

Для улучшения читаемости и понимания, рекомендуется добавить краткие комментарии к каждому состоянию, описывающие их визуальные отличия.

}
Loading
Loading