Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MindShield атмосу и ведущим должностям #271

Merged
merged 1 commit into from
Oct 14, 2024
Merged

MindShield атмосу и ведущим должностям #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Resources/Prototypes/Roles/Jobs/Engineering/atmospheric_technician.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
- Engineering
- External
- Atmospherics
special:
- !type:AddImplantSpecial
implants: [ MindShieldImplant ]
Comment on lines +19 to +21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Одобрено добавление MindShield импланта, но требуется исправление форматирования.

Добавление MindShield импланта для Атмосферного техника соответствует целям PR. Однако есть проблемы с форматированием:

  1. Отступ для строки 20 должен быть 4 пробела вместо 2.
  2. В строке 21 есть лишние пробелы внутри квадратных скобок.

Предлагаю внести следующие изменения для исправления форматирования:

 special:
-  - !type:AddImplantSpecial
-    implants: [ MindShieldImplant ]
+    - !type:AddImplantSpecial
+      implants: [MindShieldImplant]
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
special:
- !type:AddImplantSpecial
implants: [ MindShieldImplant ]
special:
- !type:AddImplantSpecial
implants: [MindShieldImplant]
🧰 Tools
🪛 yamllint

[error] 20-20: wrong indentation: expected 4 but found 2

(indentation)

[error] 21-21: too many spaces inside brackets

(brackets)

[error] 21-21: too many spaces inside brackets

(brackets)


- type: startingGear
id: AtmosphericTechnicianGear
Expand Down
3 changes: 3 additions & 0 deletions Resources/Prototypes/Roles/Jobs/Engineering/senior_engineer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
- Engineering
- External
- Atmospherics
special:
- !type:AddImplantSpecial
implants: [ MindShieldImplant ]
Comment on lines +26 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Исправьте отступы и пробелы для улучшения читаемости.

Обнаружены следующие проблемы форматирования:

  1. Неправильный отступ в строке 26 (должно быть 4 пробела вместо 2).
  2. Лишние пробелы внутри квадратных скобок в строке 27.

Предлагаю внести следующие изменения:

-  special:
-  - !type:AddImplantSpecial
-    implants: [ MindShieldImplant ]
+    special:
+    - !type:AddImplantSpecial
+      implants: [MindShieldImplant]

Committable suggestion was skipped due to low confidence.

🧰 Tools
🪛 yamllint

[error] 26-26: wrong indentation: expected 4 but found 2

(indentation)

[error] 27-27: too many spaces inside brackets

(brackets)

[error] 27-27: too many spaces inside brackets

(brackets)


- type: startingGear
id: SeniorEngineerGear
Expand Down
2 changes: 2 additions & 0 deletions Resources/Prototypes/Roles/Jobs/Medical/senior_physician.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
- Maintenance
- Chemistry
special:
- !type:AddImplantSpecial
implants: [ MindShieldImplant ]
Comment on lines +25 to +26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Исправьте отступы и пробелы в новых строках.

Обнаружены проблемы с форматированием:

  1. Неправильный отступ в строке 25. Ожидается 4 пробела, но найдено 2.
  2. Лишние пробелы внутри квадратных скобок в строке 26.

Примените следующие изменения для исправления форматирования:

-  - !type:AddImplantSpecial
-    implants: [ MindShieldImplant ]
+    - !type:AddImplantSpecial
+      implants: [MindShieldImplant]
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- !type:AddImplantSpecial
implants: [ MindShieldImplant ]
- !type:AddImplantSpecial
implants: [MindShieldImplant]
🧰 Tools
🪛 yamllint

[error] 25-25: wrong indentation: expected 4 but found 2

(indentation)

[error] 26-26: too many spaces inside brackets

(brackets)

[error] 26-26: too many spaces inside brackets

(brackets)

- !type:AddComponentSpecial
components:
- type: CPRTraining
Expand Down
3 changes: 3 additions & 0 deletions Resources/Prototypes/Roles/Jobs/Science/senior_researcher.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
- Research
# - Robotics
- Maintenance
special:
- !type:AddImplantSpecial
implants: [ MindShieldImplant ]

- type: startingGear
id: SeniorResearcherGear
Expand Down
Loading