КЕРБЕРОС!!! #263
КЕРБЕРОС!!! #263
Conversation
WalkthroughВ данном пулл-запросе добавлена новая конфигурация карты игры в файле Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
Изменения: Карта
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
- Resources/Prototypes/_LostParadise/Maps/kerberos.yml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Resources/Prototypes/_LostParadise/Maps/kerberos.yml (1)
Pattern
**/*.yml: так же в прототипах запрещены любые переводы на русский. Только на английском или ссылкой на перевод.Все добавляемые прототипы должны быть в нашей папке.
В прототипе любого предмета после поля
components:должно идти- typeна уровне с буквойcвcomponents.При удалении дополнительного дополнения по типу
prob:, можно оставить оригинальную часть с- id:.
🪛 yamllint
Resources/Prototypes/_LostParadise/Maps/kerberos.yml
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[warning] 74-74: missing starting space in comment
(comments)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 76-76: too many spaces inside brackets
(brackets)
[error] 76-76: too many spaces inside brackets
(brackets)
[error] 77-77: too many spaces inside brackets
(brackets)
[error] 77-77: too many spaces inside brackets
(brackets)
Evgencheg
added
Статус: Не мержить
Протестирован и проверен СМ (30 минут работал стабильно без перерывов) Мелкие фиксы по наводке Джея
Add LPPKerberos
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
- Resources/Prototypes/_LostParadise/Maps/kerberos.yml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Resources/Prototypes/_LostParadise/Maps/kerberos.yml (1)
Pattern
**/*.yml: так же в прототипах запрещены любые переводы на русский. Только на английском или ссылкой на перевод.Все добавляемые прототипы должны быть в нашей папке.
Никогда не предлагать ничего по отступам
При удалении дополнительного дополнения по типу
prob:, можно оставить оригинальную часть с- id:.
🪛 yamllint
Resources/Prototypes/_LostParadise/Maps/kerberos.yml
[error] 1-1: wrong new line character: expected \n
(new-lines)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[warning] 74-74: missing starting space in comment
(comments)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 76-76: too many spaces inside brackets
(brackets)
[error] 76-76: too many spaces inside brackets
(brackets)
[error] 77-77: too many spaces inside brackets
(brackets)
[error] 77-77: too many spaces inside brackets
(brackets)
🔇 Additional comments (1)
Resources/Prototypes/_LostParadise/Maps/kerberos.yml (1)
17-77: 🛠️ Refactor suggestion
⚠️ Potential issueПересмотрите баланс ролей и улучшите форматирование
- Уточните количество игроков для роли Passenger. Текущее значение [-1, -1] может вызвать проблемы.
- Проверьте баланс ролей с учетом размера карты и общего количества игроков. Например:
- Количество ServiceWorker (4-6) кажется высоким по сравнению с другими ролями.
- Убедитесь, что количество ключевых ролей (например, Captain, HeadOfSecurity) соответствует ожидаемому размеру команды.
- Улучшите форматирование списка ролей для лучшей читаемости, удалив лишние пробелы внутри квадратных скобок.
Пример улучшения форматирования:
- Bartender: [ 2, 2 ] + Bartender: [2, 2]Рассмотрите возможность уточнения количества игроков для следующих ролей:
- Passenger: [ -1, -1 ] + Passenger: [0, 10] # или другой подходящий диапазон - ServiceWorker: [ 4, 6 ] + ServiceWorker: [2, 4]Likely invalid or redundant comment.
🧰 Tools
🪛 yamllint
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[warning] 74-74: missing starting space in comment
(comments)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 76-76: too many spaces inside brackets
(brackets)
[error] 76-76: too many spaces inside brackets
(brackets)
[error] 77-77: too many spaces inside brackets
(brackets)
[error] 77-77: too many spaces inside brackets
(brackets)
| - type: gameMap | ||
| id: LPPKerberos | ||
| mapName: 'NS Керберос' | ||
| mapPath: /Maps/_LostParadise/LPPKerberos.yml | ||
| minPlayers: 30 | ||
| stations: | ||
| LPPKerberos: | ||
| stationProto: StandardNanotrasenStation | ||
| components: | ||
| - type: StationNameSetup | ||
| mapNameTemplate: '{0} NS Керберос {1}' | ||
| nameGenerator: | ||
| !type:NanotrasenNameGenerator | ||
| prefixCreator: '14' | ||
| - type: StationEmergencyShuttle | ||
| emergencyShuttlePath: /Maps/_LostParadise/Shuttles/LP_Kerberos_evac.yml | ||
| - type: StationJobs | ||
| overflowJobs: | ||
| - Passenger | ||
| availableJobs: | ||
| # Service | ||
| Bartender: [ 2, 2 ] | ||
| Botanist: [ 3, 4] | ||
| Chef: [ 2, 3 ] | ||
| Janitor: [ 2, 4 ] | ||
| Captain: [ 1, 1 ] | ||
| HeadOfPersonnel: [ 1, 1 ] | ||
| ServiceWorker: [ 4, 6 ] | ||
| # Engineering | ||
| ChiefEngineer: [ 1, 1 ] | ||
| StationEngineer: [ 4, 5 ] | ||
| AtmosphericTechnician: [ 3, 4 ] | ||
| TechnicalAssistant: [ 2, 4 ] | ||
| # Medical | ||
| ChiefMedicalOfficer: [ 1, 1 ] | ||
| MedicalDoctor: [ 4, 6 ] | ||
| Chemist: [ 2, 2 ] | ||
| MedicalIntern: [ 2, 4 ] | ||
| Paramedic: [ 1, 1 ] | ||
| MedicalBorg: [ 2, 3 ] | ||
| # RND | ||
| ResearchDirector: [ 1, 1 ] | ||
| Scientist: [ 4, 6 ] | ||
| ResearchAssistant: [ 2, 4 ] | ||
| Borg: [ 3, 6 ] | ||
| Chaplain: [ 1, 1 ] | ||
| Librarian: [ 1, 2 ] | ||
| ForensicMantis: [ 1, 2 ] | ||
| # Security | ||
| HeadOfSecurity: [ 1, 1 ] | ||
| SecurityOfficer: [ 4, 6 ] | ||
| Warden: [ 1, 1 ] | ||
| Lawyer: [ 2, 2 ] | ||
| SecurityCadet: [ 3, 4 ] | ||
| Detective: [ 1, 1 ] | ||
| Prisoner: [ 3, 4 ] | ||
| Brigmedic: [ 1, 1 ] | ||
| PrisonGuard: [ 1, 1 ] | ||
| # Logistics | ||
| CargoTechnician: [ 3, 4 ] | ||
| Quartermaster: [ 1, 1 ] | ||
| MailCarrier: [ 1, 2 ] | ||
| SalvageSpecialist: [ 3, 6 ] | ||
| # Civilian | ||
| Passenger: [ -1, -1 ] | ||
| Clown: [ 1, 1 ] | ||
| Mime: [ 1, 1 ] | ||
| Musician: [ 1, 3 ] | ||
| Reporter: [ 1, 2 ] | ||
| # Justice | ||
| Prosecutor: [ 1, 1 ] | ||
| Clerk: [ 2, 2 ] | ||
| ChiefJustice: [ 1, 1 ] | ||
| #LOST PARADISE | ||
| LPPBlueShieldOfficer: [ 1, 1 ] | ||
| LPPAdjutant: [ 1, 1 ] | ||
| LPPSecurityEngineer: [ 1, 1 ] |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Итоговые рекомендации по улучшению конфигурации карты
- Замените все русские названия на английские варианты для соответствия правилам кодирования.
- Пересмотрите минимальное количество игроков и баланс ролей для обеспечения оптимального игрового процесса.
- Проверьте существование файла шаттла эвакуации и исправьте путь, если необходимо.
- Улучшите форматирование YAML-файла, особенно в списке ролей.
Эти изменения помогут улучшить качество кода и игровой баланс карты "Kerberos".
Если вам нужна помощь в реализации этих изменений или у вас есть вопросы, не стесняйтесь обращаться. Я могу помочь с генерацией кода для конкретных изменений или предоставить дополнительные разъяснения по любому из предложенных улучшений.
🧰 Tools
🪛 yamllint
[error] 1-1: wrong new line character: expected \n
(new-lines)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 22-22: too many spaces inside brackets
(brackets)
[error] 23-23: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 24-24: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 25-25: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 26-26: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 27-27: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 28-28: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 30-30: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 31-31: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 32-32: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 33-33: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 35-35: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 36-36: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 37-37: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 38-38: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 39-39: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 40-40: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 42-42: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 43-43: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 44-44: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 45-45: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 46-46: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 47-47: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 48-48: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 50-50: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 51-51: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 52-52: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 53-53: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 54-54: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 55-55: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 56-56: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 57-57: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 58-58: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 60-60: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 61-61: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 62-62: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 63-63: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 65-65: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 66-66: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 67-67: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 68-68: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 69-69: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[error] 71-71: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 72-72: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[error] 73-73: too many spaces inside brackets
(brackets)
[warning] 74-74: missing starting space in comment
(comments)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 75-75: too many spaces inside brackets
(brackets)
[error] 76-76: too many spaces inside brackets
(brackets)
[error] 76-76: too many spaces inside brackets
(brackets)
[error] 77-77: too many spaces inside brackets
(brackets)
[error] 77-77: too many spaces inside brackets
(brackets)
| - type: gameMap | ||
| id: LPPKerberos | ||
| mapName: 'NS Керберос' | ||
| mapPath: /Maps/_LostParadise/LPPKerberos.yml | ||
| minPlayers: 30 |
There was a problem hiding this comment.
Необходимо внести изменения в метаданные карты
- Замените русское название карты "NS Керберос" на английский вариант, например, "NS Kerberos", чтобы соответствовать правилам кодирования.
- Рассмотрите возможность снижения минимального количества игроков (сейчас 30). Это значение кажется слишком высоким и может ограничить использование карты.
Предлагаемые изменения:
- mapName: 'NS Керберос'
+ mapName: 'NS Kerberos'
- minPlayers: 30
+ minPlayers: 15 # или другое подходящее значение📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - type: gameMap | |
| id: LPPKerberos | |
| mapName: 'NS Керберос' | |
| mapPath: /Maps/_LostParadise/LPPKerberos.yml | |
| minPlayers: 30 | |
| - type: gameMap | |
| id: LPPKerberos | |
| mapName: 'NS Kerberos' | |
| mapPath: /Maps/_LostParadise/LPPKerberos.yml | |
| minPlayers: 15 # или другое подходящее значение |
🧰 Tools
🪛 yamllint
[error] 1-1: wrong new line character: expected \n
(new-lines)
| stations: | ||
| LPPKerberos: | ||
| stationProto: StandardNanotrasenStation | ||
| components: | ||
| - type: StationNameSetup | ||
| mapNameTemplate: '{0} NS Керберос {1}' | ||
| nameGenerator: | ||
| !type:NanotrasenNameGenerator | ||
| prefixCreator: '14' | ||
| - type: StationEmergencyShuttle | ||
| emergencyShuttlePath: /Maps/_LostParadise/Shuttles/LP_Kerberos_evac.yml |
There was a problem hiding this comment.
💡 Codebase verification
Путь к файлу шаттла эвакуации указан неверно.
Файл шаттла эвакуации найден по пути:
Resources/Maps/_LostParadise/Shuttles/LP_Kerberos_evac.yml
Пожалуйста, обновите путь в конфигурации следующим образом:
- emergencyShuttlePath: /Maps/_LostParadise/Shuttles/LP_Kerberos_evac.yml
+ emergencyShuttlePath: /Maps/_LostParadise/Shuttles/LP_Kerberos_evac.yml🔗 Analysis chain
Исправьте шаблон имени станции и проверьте путь к шаттлу эвакуации
- Замените русский текст в шаблоне имени станции на английский вариант.
- Убедитесь, что файл шаттла эвакуации существует по указанному пути.
Предлагаемые изменения:
- mapNameTemplate: '{0} NS Керберос {1}'
+ mapNameTemplate: '{0} NS Kerberos {1}'Файл шаттла эвакуации не найден по указанному пути. Необходимо проверить правильность пути или наличие файла в других местах.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Проверка существования файла шаттла эвакуации
if [ -f "Resources/Prototypes/_LostParadise/Maps/_LostParadise/Shuttles/LP_Kerberos_evac.yml" ]; then
echo "Файл шаттла эвакуации существует."
else
echo "Ошибка: Файл шаттла эвакуации не найден."
fi
Length of output: 187
Script:
#!/bin/bash
# Поиск файла шаттла эвакуации во всем репозитории
fd "LP_Kerberos_evac.yml"
Length of output: 84
|
ДАТЫ СУКА ЗАЕБАЛ!!!! |
Описание обновления: Welcome back, Kerberos
Для тестов данная карта добавлена в сборку, НО требуется тестирование и работа напильником!! Тестеровщики должны, в ближайшее время, протестировать данную станцию и отрепортить недочёты и ошибки.
ПЕХ!ПЕХ!ПЕХ!ПЕХ!ПЕХ!ПЕХ!ПЕХ!ПЕХ!
Проверки
Изменения
🆑 PowerKAT1