-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split large rec files between multiple SpikegadgetsRawIO iterators #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
- Coverage 94.39% 90.10% -4.29%
==========================================
Files 25 25
Lines 2157 2275 +118
==========================================
+ Hits 2036 2050 +14
- Misses 121 225 +104
☔ View full report in Codecov by Sentry. |
This reverts commit cb52f19.
edeno
approved these changes
Oct 30, 2023
edeno
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excessively large iterators can cause memory issues due to lading large chunks of data into memory during
get_analogsignal_multiplexed
orget_digitalsignal
.This merge splits the memmap of these large rec files into multiple SpikegadgetsRawIO iterators. The ordering of these is tracked by the
RecDataChunkIterator
so almost any use case doesn't need to worry about this.If trying too get info for a specific epoch, note that this means there is not a 1:1 relation between iterators and epochs. Use the
file_info
pandas dataframe to determine which epoch each belongs to (seeadd_epochs
for example)