Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: benchmark of embedding and reranking #64

Merged
merged 30 commits into from
Jun 29, 2024
Merged

Conversation

LongxingTan
Copy link
Owner

Description

This PR ...

Checklist

  • Linked issues (if existing)
  • Amended changelog.md for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Thank you for joining. Have fun coding!

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 42.71845% with 59 lines in your changes missing coverage. Please review.

Project coverage is 54.53%. Comparing base (26ad6e9) to head (f3d0690).

Files Patch % Lines
src/retrievals/models/rerank.py 34.93% 54 Missing ⚠️
src/retrievals/models/base.py 66.66% 3 Missing ⚠️
src/retrievals/data/collator.py 83.33% 1 Missing ⚠️
src/retrievals/losses/arcface.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   54.69%   54.53%   -0.17%     
==========================================
  Files          30       30              
  Lines        2362     2417      +55     
==========================================
+ Hits         1292     1318      +26     
- Misses       1070     1099      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LongxingTan LongxingTan merged commit df31d6e into master Jun 29, 2024
12 checks passed
@LongxingTan LongxingTan deleted the fix/benchmark11 branch June 29, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant