Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use "copy of" for duplicated schedules and place them under the original schedule #358 #397

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

CMEONE
Copy link
Member

@CMEONE CMEONE commented Oct 28, 2024

Resolves #358


This change is Reviewable

Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, minor changes requested for code style

bonus points for the "Resolves #358"

src/pages/background/lib/duplicateSchedule.ts Outdated Show resolved Hide resolved
src/pages/background/lib/duplicateSchedule.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awaiting UX review from @IsaDavRod

Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samathingamajig Samathingamajig changed the title feat: use "copy of" for duplicated schedules and place them under the original schedule #358 feat: use "copy of" for duplicated schedules and place them under the original schedule #358 Oct 28, 2024
@Samathingamajig Samathingamajig merged commit 94744e0 into Longhorn-Developers:main Oct 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants