Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): changed popup close icon to #333F48 #394

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

shehreenr
Copy link
Contributor

@shehreenr shehreenr commented Oct 25, 2024

Issue #338: CC popup X close button should be UT Black (#333F48) to match Figma


This change is Reviewable

Copy link

sentry-io bot commented Oct 25, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/views/components/injected/CourseCatalogInjectedPopup/HeadingAndActions.tsx

Function Unhandled Issue
HeadingAndActions TypeError: Cannot destructure property 'courseName' of 'kt' as it is null. HeadingAndActions(../../src/views/components/injected/CourseCatalogInjectedPo...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

@DereC4 DereC4 added this to the v2.1.0 milestone Oct 26, 2024
@IsaDavRod IsaDavRod linked an issue Oct 27, 2024 that may be closed by this pull request
@IsaDavRod IsaDavRod self-requested a review October 27, 2024 21:40
Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awaiting review from @IsaDavRod

Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samathingamajig Samathingamajig merged commit 0077ae7 into Longhorn-Developers:main Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CC popup X close button should be UT Black (#333F48) to match Figma
4 participants