fix: bottom-aligned all calendar elements, updated calendar header & main popup layout #388
+72
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated layout after changes: |
Razboy20
previously requested changes
Oct 23, 2024
i love having 80 different ideas, hopefully after this there's like maybe a tiny commit left to do before this is done..
|
After the 4th commit listed, here's what it looks like |
|
I'm not confident about how this should look at all so pls feel free to look and figure out how I can fix what I differ with the Figma 
|
|
How it looks as of the 7th (..oops) commit |
IsaDavRod
requested changes
Nov 5, 2024
There was a problem hiding this comment.
- 1) Make sure the schedule title in calendar and main popup view is not allcaps
- 2) Remove the colon after the schedule name in calendar and main popup view
- 3) Hide the "LAST UDPATED ON..." in calendar and main popup view
- 4) The # hours, # courses can be h3 instead of h4 just to make it a little better in calendar view only (keep as h4 in main popup view)
- schedule title is now in normal casing w/ colon removed - last updated on is now entirely deleted from everywhere - hour and course numbers now h3 in calendar ONLY
|
|
warithr621
changed the title
doprz
approved these changes
Nov 6, 2024
Comment on lines
52
to
57
| <Text variant='h4' className='text-theme-black leading-[75%]!'> | ||
| {activeSchedule ? activeSchedule.courses.length : 0} | ||
| </Text> | ||
| <Text | ||
| variant='h4' | ||
| className='text-theme-black leading-[75%]!' |
There was a problem hiding this comment.
Since we're using leading-[75%] various times, does it make sense to add to our theme config instead of having it as an arbitrary value?
Samathingamajig
requested changes
Nov 12, 2024
Samathingamajig
force-pushed
the
fix/align-schedule-hours
branch
from
7ca1013
to
c4f834d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #349
Before:
After:
New Popup Layout:
Changes:
This change is