Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cancel drag on scheduling page when item moves beyond container y bounds #320 #387

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Preston-Cook
Copy link
Contributor

@Preston-Cook Preston-Cook commented Oct 23, 2024

fix: cancel drag on scheduling page when item moves beyond container y bounds #320

Before:
https://github.com/user-attachments/assets/4c41416c-6bb6-4837-93c6-0c01dc76c15e

After:
https://github.com/user-attachments/assets/5b9adecb-dd40-48a2-bdab-b3b6234443d2


This change is Reviewable

Copy link
Member

@Razboy20 Razboy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a more difficult challenge to solve than just cancelling drag.

Just to condense what is on discord, change this to constrain dragging to be relatively within the bounds of the drag container. When dragging outside, it should be able to be "pulled" slightly outside, but physically still held within the container. The other elements should also not reorder into the space that the draggable is occupying (i.e. if you drag all the way to the top of the screen, the dragged item is the top item in the list, slightly pulled upwards from where it would ultimately rest if the drag was released.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants