-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add explanation to grade distribution #325
feat: add explanation to grade distribution #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is needed. In the Figma, there is a link next to the semester dropdown "About the data" that will link (open to new tab) to UT Course Grade Distributions site. Are able to add the link to match the Figma?
bruh why are there four workflows |
e47a1c2
to
1314825
Compare
@IsaDavRod Do I need to do anything else for this pull request? It says "Changes requested", but I'm not sure if I need to do anything on my part. |
@Abdomash i dont see this PR in the PR channel as a post. Did you ever make it? I can't seem to find it. |
I didn't know I needed to add my PR to the Discord channel. Added it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the "About the data" text style/variant to small
? Other than that, looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Improve UX by Adding an Explanation to the Grade Distribution Chart
Before
After
Huly®: UTRP-321
This change is