Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add explanation to grade distribution #325

Conversation

Abdomash
Copy link
Contributor

@Abdomash Abdomash commented Oct 18, 2024

Improve UX by Adding an Explanation to the Grade Distribution Chart

  • The Other category in the grade distribution popup is somewhat ambiguous for the users, so I added a simple description underneath the chart to explain its meaning.
  • I referenced the official UT Course Grade Distribution to write this explanation. You can find their original explanation in the (?) help popup.

Before

before

After

after

Huly®: UTRP-321


This change is Reviewable

@IsaDavRod IsaDavRod self-requested a review October 19, 2024 20:42
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is needed. In the Figma, there is a link next to the semester dropdown "About the data" that will link (open to new tab) to UT Course Grade Distributions site. Are able to add the link to match the Figma?

FIGMA:
image

@Abdomash
Copy link
Contributor Author

How about this?

image

@DereC4
Copy link
Member

DereC4 commented Oct 23, 2024

bruh why are there four workflows

@IsaDavRod
Copy link
Member

How about this?

image

It would not include the detail info at the bottom.

@Abdomash Abdomash force-pushed the feat/add-grade-distribution-description branch from e47a1c2 to 1314825 Compare October 23, 2024 06:50
@Abdomash
Copy link
Contributor Author

How about this?
image

It would not include the detail info at the bottom.

I assumed from your prior comment that you liked the description and wanted me to also add the 'about the data' link. But in this case, I removed the description and kept the link. This PR now only adds the 'About the data' link.

@Abdomash
Copy link
Contributor Author

Abdomash commented Oct 30, 2024

@IsaDavRod Do I need to do anything else for this pull request?

It says "Changes requested", but I'm not sure if I need to do anything on my part.

@DereC4
Copy link
Member

DereC4 commented Nov 5, 2024

@Abdomash i dont see this PR in the PR channel as a post. Did you ever make it? I can't seem to find it.

@DereC4
Copy link
Member

DereC4 commented Nov 5, 2024

image

@DereC4 DereC4 added this to the v2.1.0 milestone Nov 5, 2024
@Abdomash
Copy link
Contributor Author

I didn't know I needed to add my PR to the Discord channel. Added it now.

Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the "About the data" text style/variant to small? Other than that, looks great!

@doprz doprz requested a review from IsaDavRod November 15, 2024 20:31
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doprz doprz merged commit 9ad3239 into Longhorn-Developers:main Nov 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Add an "About the data" link next to the semester dropdown in the Grade Distribution Chart
4 participants