Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: injected button - add all courses from MyUT AND passing URL to handler #291

Merged
merged 33 commits into from
Nov 16, 2024
Merged

feat: injected button - add all courses from MyUT AND passing URL to handler #291

merged 33 commits into from
Nov 16, 2024
+179 −49

Conversation

DereC4
Copy link
Member

@DereC4 DereC4 commented Oct 8, 2024 •
edited
Loading

we talked about this multiples already so i'm trying to work on it, just a draft PR for now to track progress

going to add a button on the myUT page

image

More details here: https://discord.com/channels/743636346727301172/1293336156704079933/1293336212689653771

EDIT: Demo

Student.-.Google.Chrome.2024-11-14.00-52-35.mp4

EDIT: Demo with async bug fixed

UTRP.Options.-.Google.Chrome.2024-11-14.17-23-34.mp4

This change is Reviewable

@DereC4 DereC4 self-assigned this Oct 8, 2024
@DereC4 DereC4 added the feature label Oct 8, 2024
@DereC4
Copy link
Member Author

DereC4 commented Oct 12, 2024

@EthanL06 u have been summoned

@DereC4 DereC4 requested a review from doprz October 14, 2024 02:05
@DereC4
Copy link
Member Author

DereC4 commented Oct 14, 2024

not for this time but in the future we will also bring back this button on this more unused webpage

image

@Samathingamajig
Copy link
Collaborator

Samathingamajig commented Oct 17, 2024 •
edited
Loading

Be aware of

Chrome warns in the console that in the future, cookies will not work when we do a network request like how we are doing it now, so might need to open a new tab (ideally a hidden/background tab, if those exist) instead

not sure if it'll still show the thing if it's initiated on the side of being on the ut domains already, since that warning was showing up when initiated from the calendar view

@DereC4 DereC4 added this to the v2.1.0 milestone Oct 22, 2024
@DereC4 DereC4 mentioned this pull request Nov 11, 2024
Closed
@DereC4 DereC4 changed the title feat: injected button to add all courses on official UT schedule feat: injected button to add all courses on official UT schedule AND passing course URL to background handler Nov 14, 2024
@DereC4 DereC4 changed the title feat: injected button to add all courses on official UT schedule AND passing course URL to background handler feat: injected button - add all courses from MyUT AND passing URL to handler Nov 14, 2024
@DereC4 DereC4 marked this pull request as ready for review November 14, 2024 06:54
@DereC4 DereC4 requested a review from sghsri November 14, 2024 06:54
@DereC4 DereC4 requested a review from Razboy20 November 14, 2024 07:11
doprz
doprz requested changes Nov 14, 2024
View reviewed changes
src/shared/util/courseUtils.ts Outdated Show resolved Hide resolved
src/views/components/injected/AddAllButton.tsx Outdated Show resolved Hide resolved
src/views/components/injected/AddAllButton.tsx Outdated Show resolved Hide resolved
src/views/components/settings/Settings.tsx Show resolved Hide resolved
src/pages/background/lib/addCourseByURL.ts Outdated Show resolved Hide resolved
src/pages/background/lib/addCourse.ts Outdated Show resolved Hide resolved
src/pages/background/lib/addCourse.ts Outdated Show resolved Hide resolved
src/pages/content/index.tsx Outdated Show resolved Hide resolved
@doprz
Copy link
Collaborator

doprz commented Nov 14, 2024

Overall this PR looks good. I requested some changes in addition that this requires further testing.

doprz
doprz approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DereC4 DereC4 linked an issue Nov 16, 2024 that may be closed by this pull request
[FEATURE] Button to add all courses from myUT schedule #431
Closed
warithr621
warithr621 approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@warithr621 warithr621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@doprz doprz self-requested a review November 16, 2024 01:05
doprz
doprz approved these changes Nov 16, 2024
View reviewed changes
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doprz
Copy link
Collaborator

doprz commented Nov 16, 2024

Note that this PR updates HOST_PERMISSIONS.

@doprz doprz merged commit c41467c into Longhorn-Developers:main Nov 16, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warithr621 warithr621 warithr621 approved these changes

@doprz doprz doprz approved these changes

@sghsri sghsri Awaiting requested review from sghsri

@Razboy20 Razboy20 Awaiting requested review from Razboy20

@IsaDavRod IsaDavRod Awaiting requested review from IsaDavRod

Assignees

@DereC4 DereC4

Labels
feature
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] Button to add all courses from myUT schedule
5 participants
@DereC4 @Samathingamajig @doprz @warithr621 @EthanL06