Bug fixes and additional suffix sort algorithms

[jzebedee]

Added Yuta Mori's induced sort
Added the option to select a SuffixSort algorithm

• bsdiff has a known bug where qsufsort can overflow the stack on files with very large matches, from recursive calls to Split (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=409664)

Replaced WriteInt64 with a faster method
Fixed an erroneous throw if a patch completes without any extra data
Fixed db/eb being allocated with an extra byte
Moved constant fields together

[amanda-mitchell]

It appears that you changed the line endings in BinaryPatchUtility.cs, which distorts the results of blame and makes it more difficult to review the actual changes.

Could you fix the line endings and push an updated commit?

[jzebedee]

Sorry to make it unclear; the source was formatted to Microsoft
convention (http://msdn.microsoft.com/en-us/library/ff926074.aspx) which
changed the indentation. You can append ?w=1 to the URL to see the diff
with whitespace ignored:

jzebedee@c563cb5?w=1

Let me know if you'd still prefer another push.

On Mon, Jul 21, 2014 at 10:53 PM, David Mitchell [email protected]
wrote:

It appears that you changed the line endings in BinaryPatchUtility.cs,
which distorts the results of blame and makes it more difficult to review
the actual changes.

Could you fix the line endings and push an updated commit?

—
Reply to this email directly or view it on GitHub
#1 (comment).

[jzebedee]

David,

I've created two new pull requests for the bugfixes and added features, respectively. They should be free of any formatting quirks. Feel free to close this one.