Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved presignedURL #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved presignedURL #29

wants to merge 1 commit into from

Conversation

Joebayld
Copy link
Collaborator

  • Improved presignedURL generation by using URLComponents
  • PresignedURLs can now sign user defined query parameters.
  • Minor cleanup to improve readability.

Improved presignedURL generation by using URLComponents.
10b127d 
PresignedURLs will now sign user defined query parameters.
Minor cleanup to improve readability.
@Joebayld Joebayld changed the title Improved presignedURL. Improved presignedURL Nov 16, 2018
@Joebayld Joebayld mentioned this pull request Nov 16, 2018
Closed
rafiki270
rafiki270 reviewed Apr 18, 2019
View reviewed changes
Copy link
Collaborator

@rafiki270 rafiki270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Joebayld, would you mind reviewing how this would go together with the current master? There is an option to choose between V2 and V4 signing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiki270 rafiki270 rafiki270 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joebayld @rafiki270