Fix simple icons color fill

[dangilbert]

Category:
One of: Bugfix

Overview
I was having problems with the SimpleIcons applying a color tint because the icons being loaded as SVGs via URL were wrapped in an object thus not allowing css styling to apply.

By including the node package for simple-icons we can directly access the SVG and PATH in order to be able to set the fill to currentColor

New Vars (if applicable)
Dependency added on simple-icons:^5.12.0

Screenshot (if applicable)
Before:

After:

Code Quality Checklist (Please complete)

• All changes are backwards compatible
• All lint checks and tests are passing
• There are no (new) build warnings or errors
• (If a new config option is added) Attribute is outlined in the schema and documented
• (If a new dependency is added) Package is essential, and has been checked out for security or performance
• Bumps version, if new feature added

[netlify]

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: c9fc7e4

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/612e0b4192dceb00079ae165

😎 Browse the preview: https://deploy-preview-194--dashy-dev.netlify.app/

[viezly]

Changes preview:

👀 Review pull request on Viezly

[Lissy93]

Looking good!
I guess the main reason I didn't use the simple-icons package in the first place, is because it's 10.5 MB

[dangilbert]

Looks like the deploy worked and then git had a failure.

And also the yarn lock change task looks like it's failing due to this:
Simek/yarn-lock-changes#26

[dangilbert]

Looking good!
I guess the main reason I didn't use the simple-icons package in the first place, is because it's 10.5 MB

Yeah, that makes sense. I couldn't find another way of altering the color of the simple icons that didn't involve using javascript to inject into the object tags, which felt a bit more convoluted than it needed to be

[Lissy93]

Just 1 small change

[Lissy93]

Yeah I think the failure in the CI is a permissions thing, it works just fine for me locally so it should be all okay

[Lissy93]

Good fix- thank you for implementing :)
I'm going to merge it, but monitor performance because of the packages size. If it has any noticable impact on the app when Simple Icons are not being used, then I might need to find a different approach.