Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Claim CLI document #73

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Add Claim CLI document #73

merged 4 commits into from
Sep 12, 2024

Conversation

Phanco
Copy link
Member

@Phanco Phanco commented Sep 9, 2024 •
edited
Loading

What was the problem?

This PR resolves #71

How was it solved?

  1. Included Claim Cli on main page of README
  2. Added Guide to using Claim CLI

@Phanco Phanco marked this pull request as ready for review September 9, 2024 09:44
@Phanco Phanco requested a review from gkoumout September 9, 2024 09:50
gkoumout
gkoumout reviewed Sep 10, 2024
View reviewed changes
Copy link

@gkoumout gkoumout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small comments, otherwise looks good to me.

README.md Show resolved Hide resolved
packages/claim-cli/README.md Show resolved Hide resolved
nagdahimanshu
nagdahimanshu reviewed Sep 12, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
nagdahimanshu
nagdahimanshu approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Phanco @nagdahimanshu
Update README.md
0304416 
Co-authored-by: Himanshu Nagda <[email protected]>
@Phanco Phanco enabled auto-merge (squash) September 12, 2024 12:29
@Phanco Phanco merged commit dc7753c into development Sep 12, 2024
1 check passed
@Phanco Phanco deleted the 71-claim-cli-doc branch September 12, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkoumout gkoumout gkoumout approved these changes

@nagdahimanshu nagdahimanshu nagdahimanshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detailed Claim CLI Documentation
3 participants
@Phanco @gkoumout @nagdahimanshu