Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Claim CLI Tool #69

Merged
merged 24 commits into from
Jul 9, 2024
Merged

Claim CLI Tool #69

merged 24 commits into from
Jul 9, 2024

Conversation

Phanco
Copy link
Member

@Phanco Phanco commented Jun 26, 2024 •
edited
Loading

What was the problem?

This PR resolves #65

How was it solved?

Implemented claim-cli tool

How was it tested?

Unit tests focuses on private key operation and signing
Multiple testing on testnet
Claimed some LSK on mainnet using this CLI😎

@Phanco Phanco self-assigned this Jun 26, 2024
@Phanco Phanco marked this pull request as ready for review June 27, 2024 08:32
nagdahimanshu
nagdahimanshu reviewed Jul 1, 2024
View reviewed changes
packages/claim-cli/README.md Outdated Show resolved Hide resolved
packages/claim-cli/package.json Outdated Show resolved Hide resolved
packages/claim-cli/README.md Outdated Show resolved Hide resolved
packages/claim-cli/src/applications/check-eligibility.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/applications/publish-multisig-claim.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/applications/submit-claim.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/utils/build-account-list.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/utils/build-account-list.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/utils/network-params.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/utils/sign-message.ts Outdated Show resolved Hide resolved
@Phanco
Copy link
Member Author

Phanco commented Jul 1, 2024 •
edited
Loading

Updated or answered all conversations 👍

nagdahimanshu
nagdahimanshu approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

shuse2
shuse2 requested changes Jul 4, 2024
View reviewed changes
packages/claim-cli/src/index.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/utils/network-params.ts Show resolved Hide resolved
packages/claim-cli/src/utils/get-private-key.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/utils/get-private-key.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/utils/get-private-key.ts Show resolved Hide resolved
@Phanco Phanco requested a review from shuse2 July 9, 2024 09:09
shuse2
shuse2 requested changes Jul 9, 2024
View reviewed changes
packages/claim-cli/src/utils/get-private-key.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/utils/get-private-key.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/utils/get-private-key.ts Outdated Show resolved Hide resolved
packages/claim-cli/src/utils/get-private-key.ts Outdated Show resolved Hide resolved
@Phanco
Copy link
Member Author

Phanco commented Jul 9, 2024

Updated to replace process.exit with throw new Error

@Phanco Phanco requested a review from shuse2 July 9, 2024 14:30
@shuse2 shuse2 merged commit 737c81d into development Jul 9, 2024
1 check passed
@shuse2 shuse2 deleted the 65-claim-cli-tool branch July 9, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@nagdahimanshu nagdahimanshu nagdahimanshu approved these changes

Assignees

@Phanco Phanco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Token claim CLI tool
3 participants
@Phanco @shuse2 @nagdahimanshu