Update default .env files
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricott1
changed the title
.env files
matjazv
requested changes
Sep 17, 2024
AndreasKendziorra
requested changes
Sep 17, 2024
Signed-off-by: ricott1 <[email protected]>
Signed-off-by: ricott1 <[email protected]>
Signed-off-by: ricott1 <[email protected]>
ricott1
force-pushed
the
improve-env-files
branch
from
7c080b2
to
d4ca137
Compare
matjazv
approved these changes
Sep 18, 2024
|
@matjazv @AndreasKendziorra Regarding the RPC URLs, should we consistently use the |
I vote for yes. Regarding L1 endpoints, we're currently using |
No strong opinion on this one. Either way is fine. |
AndreasKendziorra
requested changes
Sep 18, 2024
AndreasKendziorra
approved these changes
Sep 18, 2024
ricott1
added a commit
that referenced
this pull request
Sep 19, 2024
* Update L1_FORK_RPC_URL and L2_FORK_RPC_URL default values Signed-off-by: ricott1 <[email protected]> * Add .env.devnet file and update README Signed-off-by: ricott1 <[email protected]> * Update devnet env file and README; Improve comments in env files Signed-off-by: ricott1 <[email protected]> * Make default URLs consistent * Remove unused fork rpc URLs from public chain .env files * Remove value of unused TEST_NETWORK_MNEMONIC variable * Update the deployment description in the README --------- Signed-off-by: ricott1 <[email protected]>
matjazv
pushed a commit
that referenced
this pull request
Sep 24, 2024
#203) * feat: add WBTC deployment script and addresses for mainnet and sepolia Signed-off-by: ricott1 <[email protected]> * Update WBTC address in testnet env file Signed-off-by: ricott1 <[email protected]> * Fix log typo Signed-off-by: ricott1 <[email protected]> * Update default `.env` files (#205) * Update L1_FORK_RPC_URL and L2_FORK_RPC_URL default values Signed-off-by: ricott1 <[email protected]> * Add .env.devnet file and update README Signed-off-by: ricott1 <[email protected]> * Update devnet env file and README; Improve comments in env files Signed-off-by: ricott1 <[email protected]> * Make default URLs consistent * Remove unused fork rpc URLs from public chain .env files * Remove value of unused TEST_NETWORK_MNEMONIC variable * Update the deployment description in the README --------- Signed-off-by: ricott1 <[email protected]> * feat: add WBTC deployment script and addresses for mainnet and sepolia Signed-off-by: ricott1 <[email protected]> * Update 9_deployWBTCContract.sh --------- Signed-off-by: ricott1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The default .env files contained some values requiring an Infura API key and in general were not correctly pointing to the relevant chain.
How was it solved?
We updated the .env files accordingly.