Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sendToCustodian function to VestingWalletPaused #198

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

Phanco
Copy link
Member

@Phanco Phanco commented Aug 29, 2024

What was the problem?

This PR resolves #196

How was it solved?

Updated L2VestingWalletPaused and L1VestingWalletPaused
P.S. In foundry, single params being reverted to single line (ref). Hence the update of other files.

How was it tested?

Updated unit test

@Phanco Phanco marked this pull request as ready for review August 29, 2024 12:31
@Phanco Phanco requested review from matjazv and sergeyshemyakov and removed request for matjazv August 29, 2024 12:52
Copy link
Contributor

@sergeyshemyakov sergeyshemyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions to documentation

src/L1/paused/L1VestingWalletPaused.sol Show resolved Hide resolved
src/L2/paused/L2VestingWalletPaused.sol Show resolved Hide resolved
src/L2/paused/L2VestingWalletPaused.sol Show resolved Hide resolved
@Phanco Phanco requested a review from has5aan August 29, 2024 13:22
@Phanco Phanco merged commit 87f50bc into development Aug 29, 2024
4 checks passed
@Phanco Phanco deleted the 196-vesting-wallet-paused-with-send-to-custodian branch August 29, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vesting Wallet Emergency Withdraw Contract
3 participants