Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Output commands to execute post migration #189

Merged

Conversation

nagdahimanshu
Copy link
Contributor

@nagdahimanshu nagdahimanshu commented Oct 17, 2023

What was the problem?

This PR resolves #188

How was it solved?

  • All the necessary commands are output to a file in their order of execution
  • User is notified of the output file generated with the list of commands to be executed

How was it tested?

  • Local against mainnet

@nagdahimanshu nagdahimanshu self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #189 (53448b0) into release/2.0.0 (5da7a99) will decrease coverage by 0.40%.
Report is 17 commits behind head on release/2.0.0.
The diff coverage is 52.94%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/2.0.0     #189      +/-   ##
=================================================
- Coverage          81.62%   81.23%   -0.40%     
=================================================
  Files                 22       24       +2     
  Lines                724      778      +54     
  Branches             104      111       +7     
=================================================
+ Hits                 591      632      +41     
- Misses               133      146      +13     
Files Coverage Δ
src/constants.ts 100.00% <100.00%> (ø)
src/utils/fs.ts 100.00% <100.00%> (ø)
src/utils/commands.ts 93.54% <93.54%> (ø)
src/utils/exception.ts 20.00% <20.00%> (ø)
src/utils/node.ts 43.96% <12.82%> (-2.34%) ⬇️

@nagdahimanshu nagdahimanshu force-pushed the 188-output-commands-to-execute-post-migration branch 2 times, most recently from 759c198 to 777bf13 Compare October 19, 2023 12:38
@nagdahimanshu nagdahimanshu force-pushed the 188-output-commands-to-execute-post-migration branch from 777bf13 to d069f97 Compare October 19, 2023 15:15
@nagdahimanshu nagdahimanshu marked this pull request as ready for review October 19, 2023 16:04
@sameersubudhi sameersubudhi force-pushed the 188-output-commands-to-execute-post-migration branch 7 times, most recently from 499e04e to 0e85fa4 Compare October 23, 2023 08:23
@sameersubudhi sameersubudhi force-pushed the 188-output-commands-to-execute-post-migration branch from 0e85fa4 to 5c62737 Compare October 23, 2023 08:26
src/utils/commands.ts Show resolved Hide resolved
@sameersubudhi sameersubudhi merged commit 540dc7e into release/2.0.0 Oct 23, 2023
6 of 8 checks passed
@sameersubudhi sameersubudhi deleted the 188-output-commands-to-execute-post-migration branch October 23, 2023 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants