Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Migrator crashes if unexpected directories exist under config directory #180

Conversation

sameersubudhi
Copy link
Contributor

What was the problem?

This PR resolves #175

How was it solved?

  • Add null checks for conditional checks when migrating user config
  • Default log level to info when migrating the user config, when getLogLevel errors out
  • Determine the network based on the v3 networkIdentifier instead of blindly reading the directory name

How was it tested?

Locally

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #180 (c836ba1) into release/2.0.0 (3cbb8a1) will decrease coverage by 0.48%.
Report is 3 commits behind head on release/2.0.0.
The diff coverage is 82.35%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/2.0.0     #180      +/-   ##
=================================================
- Coverage          86.42%   85.95%   -0.48%     
=================================================
  Files                 19       19              
  Lines                582      591       +9     
  Branches              81       82       +1     
=================================================
+ Hits                 503      508       +5     
- Misses                79       83       +4     
Files Coverage Δ
src/utils/config.ts 88.46% <82.35%> (-2.45%) ⬇️

... and 1 file with indirect coverage changes

@sameersubudhi sameersubudhi force-pushed the 175-migrator-crashes-if-unexpected-directories-exist-under-config-directory branch 2 times, most recently from 31b773f to 8a3522c Compare September 28, 2023 09:02
@sameersubudhi sameersubudhi force-pushed the 175-migrator-crashes-if-unexpected-directories-exist-under-config-directory branch from 8a3522c to 8fe1d2f Compare September 28, 2023 09:11
@sameersubudhi sameersubudhi force-pushed the 175-migrator-crashes-if-unexpected-directories-exist-under-config-directory branch from ece9ad7 to 5e3f695 Compare September 28, 2023 09:22
src/utils/config.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vardan10 vardan10 merged commit 0f552bf into release/2.0.0 Sep 29, 2023
6 of 8 checks passed
@vardan10 vardan10 deleted the 175-migrator-crashes-if-unexpected-directories-exist-under-config-directory branch September 29, 2023 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrator crashes if unexpected directories exist under config directory
3 participants