Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update migrator to read the node snapshot #133

Merged
merged 12 commits into from
Aug 16, 2023

Conversation

nagdahimanshu
Copy link
Contributor

@nagdahimanshu nagdahimanshu commented Aug 7, 2023

What was the problem?

This PR resolves #131

How was it solved?

  • Remove support for min-compatible-version, snapshot-path and use-existing-snapshot, if min-compatible-version is forced to 3.0.5 in the application
  • Lisk Migrator validates from the node:info (Lisk Core v3) if the backup.height matches the user specified snapshot_height
  • Once the snapshot-height is finalized, the migrator now reads the backup (~/.lisk/lisk-core/data/backup by default or /data/backup) to start the migration process
  • Update lisk-db version and refactor code
  • Fix unit tests
  • Update docs

How was it tested?

Local against testnet

@nagdahimanshu nagdahimanshu self-assigned this Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #133 (840d9b7) into release/2.0.0 (dda7e2b) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/2.0.0     #133      +/-   ##
=================================================
+ Coverage          93.34%   93.49%   +0.15%     
=================================================
  Files                 20       20              
  Lines                556      569      +13     
  Branches              70       74       +4     
=================================================
+ Hits                 519      532      +13     
  Misses                37       37              
Files Changed Coverage Δ
src/assets/pos.ts 92.85% <100.00%> (+1.07%) ⬆️
src/constants.ts 100.00% <100.00%> (ø)
src/createAsset.ts 97.18% <100.00%> (ø)
src/utils/transaction.ts 100.00% <100.00%> (ø)

@nagdahimanshu nagdahimanshu marked this pull request as ready for review August 15, 2023 12:43
src/assets/pos.ts Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@nagdahimanshu nagdahimanshu force-pushed the 131-update-migrator-to-read-the-node-snapshot branch from a0ee7b6 to 0415562 Compare August 16, 2023 07:37
src/index.ts Outdated Show resolved Hide resolved
@vardan10 vardan10 merged commit 31b4021 into release/2.0.0 Aug 16, 2023
6 checks passed
@vardan10 vardan10 deleted the 131-update-migrator-to-read-the-node-snapshot branch August 16, 2023 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants