👌 Apply code review suggestions

src/utils/config.ts

@@ -31,17 +31,6 @@ import {
 } from '../constants';
 import { resolveAbsolutePath } from './fs';
 
-export const NETWORKS = Object.freeze([
- {
- name: 'mainnet',
- networkID: '4c09e6a781fc4c7bdb936ee815de8f94190f8a7519becd9de2081832be309a99',
- },
- {
- name: 'testnet',
- networkID: '15f0dacc1060e91818224a94286b13aa04279c640bd5d6f193182031d133df7c',
- },
-]);
-
 const LOG_LEVEL_PRIORITY = Object.freeze({
  FATAL: 0,
  ERROR: 1,
@@ -52,8 +41,10 @@ const LOG_LEVEL_PRIORITY = Object.freeze({
 }) as Record<string, number>;
 
 export const getNetworkByNetworkID = (_networkID: string): string | Error => {
- const networkInfo = NETWORKS.find(info => info.networkID === _networkID);
- if (!networkInfo) throw new Error('Migrator running against unsupported network.');
+ const networkInfo = NETWORK_CONSTANT[_networkID];
+ if (!networkInfo) {
+ throw new Error('Migrator running against unidentified network. Cannot proceed.');
+ }
  return networkInfo.name;
 };
 
@@ -80,7 +71,7 @@ export const getConfig = async (
  _networkID: string,
  customConfigPath?: string,
 ): Promise<ApplicationConfigV3> => {
- let network: String | Error = 'mainnet';
+ let network: string | Error = 'mainnet';
  try {
  network = getNetworkByNetworkID(_networkID);
  } catch (err) {

src/utils/genesis_block.ts

@@ -20,12 +20,14 @@ import { GenesisAssetEntry } from '../types';
 import { execAsync } from './process';
 import { copyFile } from './fs';
 
+/* eslint-disable func-names, @typescript-eslint/no-explicit-any */
 (BigInt.prototype as any).toJSON = function () {
  return this.toString();
 };
 (Buffer.prototype as any).toJSON = function () {
  return this.toString('hex');
 };
+/* eslint-enable func-names, @typescript-eslint/no-explicit-any */
 
 export const createChecksum = async (filePath: string): Promise<string> => {
  const fileStream = fs.createReadStream(filePath);

test/unit/utils/config.spec.ts

@@ -15,8 +15,8 @@ import * as fs from 'fs-extra';
 import { resolve, join } from 'path';
 import { ApplicationConfig } from 'lisk-framework';
 import { configV3, configV4 } from '../fixtures/config';
+import { NETWORK_CONSTANT } from '../../../src/constants';
 import {
- NETWORKS,
  getNetworkByNetworkID,
  migrateUserConfig,
  validateConfig,
@@ -62,15 +62,15 @@ describe('Migrate user configuration', () => {
 
 describe('Test networkIdentifier method', () => {
  it('should determine network correctly by networkIdentifier', async () => {
- NETWORKS.forEach(networkInfo => {
- const network = getNetworkByNetworkID(networkInfo.networkID);
- expect(network).toBe(networkInfo.name);
+ Object.keys(NETWORK_CONSTANT).forEach(networkID => {
+ const network = getNetworkByNetworkID(networkID);
+ expect(network).toBe(NETWORK_CONSTANT[networkID].name);
  });
  });
 
  it('should throw error with unknown networkIdentifier', async () => {
- expect(() => getNetworkByNetworkID('unknown network identifier')).toThrowError(
- 'Migrator running against unsupported network.',
+ expect(() => getNetworkByNetworkID('unknown network identifier')).toThrow(
+ 'Migrator running against unidentified network. Cannot proceed.',
  );
  });
 });