Simplify osascript handling
#61
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a few changes, somewhat independent, but all related: * defaults `auto-dark-allow-osascript` to true[^1]; * falls back to `osascript` on-demand if neither `ns-do-applescript` nor `mac-do-applescript` is available[^2]; and * removes `osascript` as a separate `auto-dark-detection-method`[^3]. These can be easily separated depending on which, if any, you think are improvements. [^1]: I don’t know why this is even a variable. If it’s not allowed, then there is no way to use Auto-Dark on systems that require it, and the failure mode is opaque (“Could not determine a viable theme detection mechanism!”). [^2]: If this change isn’t made, then the error message “Try setting `auto-dark-allow-osascript` to t” doesn’t make sense, as it’s only reported in a location where the value of `auto-dark-allow-osascript` has no effect. The alternative is to change the error message to something like “`auto-dark-detection-method` indicates that this Emacs build has AppleScript support, but none could be found. Either rebuild Emacs with AppleScript support or change the detection method and set `auto-dark-allow-osascript`”. [^3]: With LionyxML#59, the two `fboundp` checks added before falling back to `osascript` should be more than outweighed by the removal of shell invocation.
sellout
force-pushed
the
simplify-osascript
branch
from
cd56b90
to
a6172e1
Compare
|
Another question I had somewhat related to this … I had considered unifying the |
sellout
added a commit
to sellout/auto-dark-emacs
that referenced
this pull request
Jul 14, 2024
Rather than just saying that we _couldn’t_ determine the detection method, this indicates why and makes some suggestions. Probably even longer errors with concrete steps to remedy each case would be helpful. This includes an alternative approach to the first bullet point in LionyxML#61 – changing where we suggest that `auto-dark-allow-osascript` should be enabled (although this does not change the error that suggests it in the wrong place).
|
you can have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes, somewhat independent, but all related:
auto-dark-allow-osascriptto true1;osascripton-demand if neitherns-do-applescriptnormac-do-applescriptis available2; andosascriptas a separateauto-dark-detection-method3.These can be easily separated depending on which, if any, you think are improvements.
Footnotes
I don’t know why this is even a variable. If it’s not allowed, then there is no way to use Auto-Dark on systems that require it, and the failure mode is opaque (“Could not determine a viable theme detection mechanism!”). There’s probably something I’m overlooking, but if so, it should be documented. ↩
If this change isn’t made, then the error message “Try setting
auto-dark-allow-osascriptto t” doesn’t make sense, as it’s only reported in a location where the value ofauto-dark-allow-osascripthas no effect. The alternative is to change the error message to something like “auto-dark-detection-methodindicates that this Emacs build has AppleScript support, but none could be found. Either rebuild Emacs with AppleScript support or change the detection method and setauto-dark-allow-osascript”. ↩With Simplify AppleScript handling #59, the two
fboundpchecks added before falling back toosascriptshould be more than outweighed by the removal of shell invocation. ↩