Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This package doesn't work under WSL, so I've come up with my own detection method and patched it in.
It evaluates
(string-match "microsoft-standard-WSL" (shell-command-to-string "uname -a"))
to find out whether the host system is WSL(the only way to detect a WSL host, to my knowledge). The dark theme detection method is similar to the methodpowershell
, the difference is because running a Windows shell under Linux shell under Emacs makes string comparison complicated. It looks scuffed, but it works well.I only tested this patch under WSL so I don't know for certain if it doesn't break under other systems. It shouldn't AFAIK, but I'm new to Emacs so there's a possibility I introduced my changes in an incorrect/dangerous way. If there are any problems that need fixing, feel free to reach out to me or change the code as you see fit.