Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Compatible): Fix ImageProvider Registration #14

Merged
merged 3 commits into from
Dec 23, 2024
Merged

fix(Compatible): Fix ImageProvider Registration #14

merged 3 commits into from
Dec 23, 2024

Conversation

elysia-best
Copy link
Contributor

@elysia-best elysia-best commented Dec 23, 2024 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR should fix the registration for IconThemeProvider.

  • What is the current behavior? (You can also link to an open issue here)

Currently the migrated code did not register the IconThemeProvider correctly.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

Tested with calculator

image

@elysia-best elysia-best self-assigned this Dec 23, 2024
@elysia-best elysia-best marked this pull request as ready for review December 23, 2024 14:39
@elysia-best elysia-best added the bug Something isn't working label Dec 23, 2024
@kodiakhq kodiakhq bot merged commit 28690cb into main Dec 23, 2024
4 checks passed
@chun-awa chun-awa deleted the fix--ImageProvider-registration branch December 23, 2024 22:09
elysia-best added a commit that referenced this pull request Jan 23, 2025
@elysia-best
fix(Compatible): Fix ImageProvider Registration (#14)
69083c7 
* feat(Compatible): Add LingmoUI module and update CMakeLists.txt

* refactor(LingmoUI): Move registerTypes to LingmoUI namespace

* fix: correct component URL path in lingmoui.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chun-awa chun-awa chun-awa approved these changes

@Redish101 Redish101 Awaiting requested review from Redish101

@Intro-iu Intro-iu Awaiting requested review from Intro-iu

@lingmo-dream lingmo-dream Awaiting requested review from lingmo-dream

Assignees

@elysia-best elysia-best

Labels
bug Something isn't working 🚀 merge it!
Projects
Lingmo OS 3.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elysia-best @chun-awa