Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onchain job creator compatibility with full path to repo #458

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arsen3d
Copy link
Contributor

@arsen3d arsen3d commented Nov 28, 2024

Summary

The existed demo of on chain cowsay did not provide a way to pass in a repo path. Just repo name.
The update supports passing in a repo path, the same way we do it cli.

@arsen3d arsen3d requested a review from a team as a code owner November 28, 2024 01:58
@cla-bot cla-bot bot added the cla-signed label Nov 28, 2024
@github-actions github-actions bot added the fix label Nov 28, 2024
@arsen3d arsen3d requested a review from bgins November 28, 2024 01:58
@arsen3d arsen3d self-assigned this Nov 28, 2024
@bgins
Copy link
Contributor

bgins commented Dec 2, 2024

@arsen3d how can we test this change? We have a client in run-cowsay-onchain.ts that has a runCowsay helper function, but it's not clear to me how this helper method works:

const runjobTx = await client
.connect(getWallet('job_creator'))
.runCowsay(message)

Is there another way to test?

Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants