Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to bacalhau 1.5 #441

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: Upgrade to bacalhau 1.5 #441

wants to merge 10 commits into from

Conversation

kelindi
Copy link
Contributor

@kelindi kelindi commented Nov 15, 2024

Summary

This pull request makes the following changes:

  • Upgrades Bacalhau to 1.5
  • Job Translator to support current lilypadspec
  • Removes Bacalhau cli usage and switches to API
  • Removes IPFS dependancy

Important Changes and Notes for clean up

  1. The RP polls bacalhau every 10 seconds to see if a job has been completed, we can change the frequency of this later on to improve the speed of jobs
  2. Right now the host and port for the Bacalhau api are hard coded. Need to update this to be values that are accessed from the env
  3. We retrieve the results from Bacalhau assuming the root Bacalhau folder is under the home directory in the same container as the rp. If we are running Bacalhau in docker it may cause some issues. I think we should running the rp and Bacalhau in the same docker container if possible.
  4. I have added some new stack commands I used for testing, dev1 (runs chain-clean and chain) dev2(runs chain-boot and solver) dev3 (starts bacalhau) dev4(runs the rp). Found this useful. Can remove it if it doesn't make sense to include

Task/Issue reference

https://github.com/orgs/Lilypad-Tech/projects/4/views/16?pane=issue&itemId=69432010&issue=Lilypad-Tech%7Cinternal%7C128

Test plan

WIP

@kelindi kelindi self-assigned this Nov 15, 2024
@kelindi kelindi requested a review from a team as a code owner November 15, 2024 18:27
@cla-bot cla-bot bot added the cla-signed label Nov 15, 2024
@kelindi kelindi changed the title Bacalhau 1.5 Update Bacalhau 1.5 Upgrade Nov 15, 2024
@kelindi kelindi changed the title Bacalhau 1.5 Upgrade [Feat] Upgrade to bacalhau 1.5 Nov 15, 2024
Copy link
Collaborator

@walkah walkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. let's get it rebased and cleaned up. lots of questions above

pkg/executor/bacalhau/bacalhau.go Show resolved Hide resolved
pkg/executor/bacalhau/bacalhau.go Outdated Show resolved Hide resolved
pkg/executor/bacalhau/bacalhau.go Outdated Show resolved Hide resolved
pkg/executor/bacalhau/bacalhau.go Show resolved Hide resolved
pkg/executor/bacalhau/bacalhau.go Outdated Show resolved Hide resolved
pkg/executor/bacalhau/client.go Show resolved Hide resolved
pkg/jobcreator/onchain_jobcreator.go Outdated Show resolved Hide resolved
pkg/solver/client.go Outdated Show resolved Hide resolved
pkg/system/log.go Show resolved Hide resolved
stack Outdated Show resolved Hide resolved
@walkah walkah changed the title [Feat] Upgrade to bacalhau 1.5 feat: Upgrade to bacalhau 1.5 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants