Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable warning message for gpu info #437

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: disable warning message for gpu info #437

wants to merge 2 commits into from

Conversation

arsen3d
Copy link
Contributor

@arsen3d arsen3d commented Nov 14, 2024

Summary

Adding this parameter removes:

WARNING: failed to determine nodes: open /sys/devices/system/node: no such file or directory
WARNING: failed to read int from file: open /sys/class/drm/card0/device/numa_node: no such file or directory
WARNING: failed to determine nodes: open /sys/devices/system/node: no such file or directory
WARNING: error parsing the pci address "vgem"

from output

@arsen3d arsen3d requested a review from a team as a code owner November 14, 2024 17:05
@cla-bot cla-bot bot added the cla-signed label Nov 14, 2024
@arsen3d arsen3d requested a review from bgins November 14, 2024 17:05
@github-actions github-actions bot added the fix label Nov 14, 2024
bgins
bgins reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good catch to disable these warnings.

The change to .gitignore seems unrelated. Could we remove that from the PR?

@bgins
Copy link
Contributor

bgins commented Nov 14, 2024

We might also want to rename the task here to chore instead of fix. Displaying a warning message is not a bug, the change here is more of a clean up chore.

@arsen3d arsen3d self-assigned this Nov 14, 2024
@arsen3d arsen3d force-pushed the arsen/fix-gpu-warning-message branch from 75ebf9c to 027156d Compare November 14, 2024 18:54
@arsen3d arsen3d force-pushed the arsen/fix-gpu-warning-message branch from 027156d to 812ffb7 Compare November 14, 2024 19:01
bgins
bgins approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✨

@arsen3d arsen3d changed the title fix: disable warning message for gpu info chore: disable warning message for gpu info Nov 25, 2024
@github-actions github-actions bot added chore and removed fix labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgins bgins bgins approved these changes

Assignees

@arsen3d arsen3d

Labels
chore cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arsen3d @bgins