feat: add user side hashrate #289
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alvin-reyes
reviewed
Aug 24, 2024
| @@ -95,7 +96,7 @@ contract LilypadPow is Initializable, OwnableUpgradeable { | |||
| } | |||
|
|
|||
| // submitWork miner submint a nonce value, sc check the difficulty and emit a valid pow event when success | |||
| function submitWork(uint256 nonce, string calldata nodeId) external { | |||
| function submitWork(uint256 nonce, string calldata nodeId, uint256 report_hashrates) external { | |||
There was a problem hiding this comment.
Why is it report_hashrates? Should it be report_hashrate (without 's')?
Also, I think we should name it to computed_hashrate for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Type Requested (choose one):
Summary
Provide a one line summary and link to any relevant references
Task/Issue reference
Closes: https://github.com/Lilypad-Tech/internal/issues/188
Details (optional)
Add any additional details that might help Code Reviewers digest this PR
How to test this code? (optional)
Anything else? (optional)