hotfix: announcement bookmark device id null

LikeKNU · May 10, 2024 · a54c6cf · a54c6cf
1 parent e7773ab
commit a54c6cf
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/src/main/java/ac/knu/likeknu/service/AnnouncementService.java b/src/main/java/ac/knu/likeknu/service/AnnouncementService.java
@@ -6,7 +6,6 @@
 import ac.knu.likeknu.domain.Device;
 import ac.knu.likeknu.domain.constants.Campus;
 import ac.knu.likeknu.domain.constants.Category;
-import ac.knu.likeknu.exception.BusinessException;
 import ac.knu.likeknu.repository.AnnouncementRepository;
 import ac.knu.likeknu.repository.DeviceRepository;
 import org.springframework.data.domain.Page;
@@ -48,15 +47,12 @@ public List<AnnouncementListResponse> getAnnouncements(Campus campus, Category c
 
         if (deviceId != null) {
             Optional<Device> findDevice = deviceRepository.findById(deviceId);
-            if (findDevice.isEmpty()) {
+            if (findDevice.isPresent()) {
+                Device device = findDevice.get();
                 return announcementsPage.stream()
-                        .map(AnnouncementListResponse::of)
+                        .map(announcement -> AnnouncementListResponse.of(announcement, device.getBookmarks()))
                         .toList();
             }
-            Device device = findDevice.get();
-            return announcementsPage.stream()
-                    .map(announcement -> AnnouncementListResponse.of(announcement, device.getBookmarks()))
-                    .toList();
         }
         return announcementsPage.stream()
                 .map(AnnouncementListResponse::of)
@@ -71,10 +67,17 @@ public List<AnnouncementListResponse> searchAnnouncements(Campus campus, PageDto
         Slice<Announcement> announcementsPage = announcementRepository
                 .findByCampusInAndAnnouncementTitleContains(Set.of(campus, Campus.ALL), keyword, pageRequest);
 
-        Device device = deviceRepository.findById(deviceId)
-                .orElseThrow(() -> new BusinessException(String.format("Device not found! [%s]", deviceId)));
+        if (deviceId != null) {
+            Optional<Device> findDevice = deviceRepository.findById(deviceId);
+            if (findDevice.isPresent()) {
+                Device device = findDevice.get();
+                return announcementsPage.stream()
+                        .map(announcement -> AnnouncementListResponse.of(announcement, device.getBookmarks()))
+                        .toList();
+            }
+        }
         return announcementsPage.stream()
-                .map(announcement -> AnnouncementListResponse.of(announcement, device.getBookmarks()))
+                .map(AnnouncementListResponse::of)
                 .toList();
     }
 }