Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to control the truncation in bert score #2776

Merged
merged 10 commits into from
Oct 11, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 10, 2024

What does this PR do?

Fixes #2673

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2776.org.readthedocs.build/en/2776/

@SkafteNicki SkafteNicki added bug / fix Something isn't working enhancement New feature or request topic: Text labels Oct 10, 2024
@SkafteNicki SkafteNicki added this to the v1.5.0 milestone Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40%. Comparing base (a15ef9a) to head (ab2f08b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2776     +/-   ##
========================================
- Coverage      69%     40%    -30%     
========================================
  Files         334     334             
  Lines       18152   18153      +1     
========================================
- Hits        12569    7180   -5389     
- Misses       5583   10973   +5390     

@Borda
Copy link
Member

Borda commented Oct 10, 2024

@SkafteNicki looks good, lets just check the typing :)

@mergify mergify bot added the ready label Oct 10, 2024
@mergify mergify bot removed the ready label Oct 10, 2024
@mergify mergify bot added the ready label Oct 10, 2024
@Borda
Copy link
Member

Borda commented Oct 10, 2024

@SkafteNicki, do you have any idea why it takes so long on PT 1.13?
image

@SkafteNicki
Copy link
Member Author

@SkafteNicki, do you have any idea why it takes so long on PT 1.13? image

Not sure. If we just look at one of the new tests in this PR on 1.X it takes 75sec and in 2.X it takes 8sec. On my local laptop it takes around 4sec so it must be the 1.X build that something is wrong with.
What I can see is that all the tests that are really slow for the 1.X build is decorated with the skip_on_connection_issues decorator so I assume that maybe we are just seeing some connection issues for that build.

@SkafteNicki
Copy link
Member Author

@Borda this time all of them took approximately the same amount of time so lets assume that it was a connection issue

@mergify mergify bot removed the has conflicts label Oct 11, 2024
@Borda Borda merged commit 0990ecf into master Oct 11, 2024
62 checks passed
@Borda Borda deleted the bugfix/bert_truncation branch October 11, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working enhancement New feature or request ready topic: Text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

truncation cause error while using bert_score
2 participants