Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor stable update & update docs [rebase & merge] #20305

Merged
merged 14 commits into from
Sep 27, 2024
Merged

minor stable update & update docs [rebase & merge] #20305

merged 14 commits into from
Sep 27, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 26, 2024 •
edited
Loading

update docs with icons
closes #20297

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20305.org.readthedocs.build/en/20305/

GdoongMathew and others added 13 commits September 26, 2024 17:57
@GdoongMathew @Borda
Re-enable passing BytesIO as path in .to_onnx() (#20172)
bf5f860 
(cherry picked from commit 828fd99)
@williamFalcon @Borda
Update README.md
d9c121f 
(cherry picked from commit 025c30e)
@Borda
docs: adding link to forecasting studio (#20196)
7b81e5e 
* docs: adding link to forecasting studio

* lint

(cherry picked from commit f6627ea)
@Borda
docs: adding link to recommendation studio (#20197)
8acb594 
* docs: adding link to recommendation studio

* line

(cherry picked from commit f5bc685)
@williamFalcon @Borda
Update README.md
c35a7eb 
(cherry picked from commit f3f10d4)
@pl-ghost @Borda
docs: update ref to latest tutorials (#20262)
a36eb54 
update tutorials to `3f8a254d`

Co-authored-by: Borda <[email protected]>
(cherry picked from commit bc3c9c5)
@pl-ghost @Borda
docs: update ref to latest tutorials (#20284)
2658305 
update tutorials to `d5273534`

Co-authored-by: Borda <[email protected]>
(cherry picked from commit 7d2b859)
@dependabot @Borda
build(deps): bump Lightning-AI/utilities from 0.11.6 to 0.11.7 (#20267)
be438e6 
* build(deps): bump Lightning-AI/utilities from 0.11.6 to 0.11.7

Bumps [Lightning-AI/utilities](https://github.com/lightning-ai/utilities) from 0.11.6 to 0.11.7.
- [Release notes](https://github.com/lightning-ai/utilities/releases)
- [Changelog](https://github.com/Lightning-AI/utilities/blob/main/CHANGELOG.md)
- [Commits](Lightning-AI/utilities@v0.11.6...v0.11.7)

---
updated-dependencies:
- dependency-name: Lightning-AI/utilities
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Apply suggestions from code review

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 9490915)
@dependabot @Borda
build(deps): bump peter-evans/create-pull-request from 6 to 7 (#20266)
225acb2 
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6 to 7.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v6...v7)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 7eafab9)
@EmilieLny @Borda
Update favicon to match Lightning AI app consistency (#20290)
5453522 
* Update favicon

* Update favicons - all sizes

(cherry picked from commit 48279a7)
@Borda
fix(ci): update for breaking change with upload/download (#20304)
1cc1c0d 
(cherry picked from commit e452fe8)
@Borda
fix(tests): update tests after torch 2.4.1 (#20302)
143b6d0 
* update

* test_loggers_pickle_all

* more...

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit d1ca3c6)
@Borda
docs: fix broken links to W&B (#20298)
24c5ad3 
(cherry picked from commit 70f188b)
@github-actions github-actions bot added docs Documentation related ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file package labels Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.2) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
pl-cpu (macOS-14, lightning, 3.12, 2.4) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.12, 2.4) success ✅
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.2) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
pl-cpu (windows-2022, lightning, 3.12, 2.4) success ✅
pl-cpu (macOS-14, pytorch, 3.9, 2.1) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 2.1) success ✅
pl-cpu (macOS-12, pytorch, 3.10, 2.1) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.10, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 2.1) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/loggers/wandb.py, tests/tests_pytorch/callbacks/test_early_stopping.py, tests/tests_pytorch/checkpointing/test_model_checkpoint.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/test_datasets.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_logger.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/models/test_onnx.py, pyproject.toml.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success ✅
pytorch-lightning (GPUs) (testing PyTorch | latest) success ✅

These checks are required after the changes to .azure/gpu-tests-pytorch.yml, src/lightning/pytorch/core/module.py, src/lightning/pytorch/loggers/wandb.py, tests/tests_pytorch/callbacks/test_early_stopping.py, tests/tests_pytorch/checkpointing/test_model_checkpoint.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/test_datasets.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_logger.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/models/test_onnx.py, pyproject.toml, src/lightning/fabric/utilities/imports.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success ✅

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/loggers/wandb.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, docs/source-fabric/_static/images/icon.svg, docs/source-fabric/_static/images/logo-large.svg, docs/source-fabric/_static/images/logo-small.svg, .github/workflows/docs-build.yml, pyproject.toml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to src/lightning/pytorch/core/module.py, src/lightning/pytorch/loggers/wandb.py, docs/source-pytorch/_static/images/icon.svg, docs/source-pytorch/visualize/supported_exp_managers.rst, _notebooks, .github/workflows/docs-build.yml, pyproject.toml.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
fabric-cpu (macOS-14, lightning, 3.12, 2.4) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.12, 2.4) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
fabric-cpu (windows-2022, lightning, 3.12, 2.4) success ✅
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success ✅
fabric-cpu (macOS-12, fabric, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 2.1) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, pyproject.toml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success ✅
lightning-fabric (GPUs) (testing Lightning | latest) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/imports.py, pyproject.toml.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/typing.txt, src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/loggers/wandb.py, pyproject.toml.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.9) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.9) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.9) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-12, fabric, 3.9) success ✅
install-pkg (macOS-12, fabric, 3.11) success ✅
install-pkg (macOS-12, pytorch, 3.9) success ✅
install-pkg (macOS-12, pytorch, 3.11) success ✅
install-pkg (macOS-12, lightning, 3.9) success ✅
install-pkg (macOS-12, lightning, 3.11) success ✅
install-pkg (macOS-12, notset, 3.9) success ✅
install-pkg (macOS-12, notset, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.9) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.9) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.9) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.9) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to .github/workflows/_build-packages.yml, src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/loggers/wandb.py, requirements/typing.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda changed the base branch from master to release/stable September 26, 2024 16:16
@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (2129fdf) to head (2af7f99).
Report is 14 commits behind head on release/stable.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release/stable   #20305   +/-   ##
===============================================
- Coverage              89%      89%   -0%     
===============================================
  Files                 267      267           
  Lines               23076    23080    +4     
===============================================
- Hits                20579    20533   -46     
- Misses               2497     2547   +50

@lexierule lexierule merged commit 2461412 into release/stable Sep 27, 2024
123 checks passed
@lexierule lexierule deleted the releasing/update branch September 27, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file docs Documentation related fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Borda @lexierule @GdoongMathew @williamFalcon @pl-ghost @EmilieLny