Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RichProgressBar visible for both light and dark background #20260

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

tshu-w
Copy link
Contributor

@tshu-w tshu-w commented Sep 7, 2024

What does this PR do?

Fixes #17118 by

  1. No explicitly set the font color to white (use the default font color)
  2. Replace grey with dim
  3. Remove unnecessary colab hacks (we don't need to detect the background theme as Fix RichProgressBar visibility #17532, Update rich_progress.py #18505, and Fix/rich progressbar visibility #19239)

Before:
Screenshot 2024-09-07 at 15 34 17
Screenshot 2024-09-07 at 15 34 42
After:
Screenshot 2024-09-07 at 15 38 59
Screenshot 2024-09-07 at 15 39 21

I am open to feedback regarding the style changes I have made and the following command will give the preview of rich default styles.

python -m rich.default_styles
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 7, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81%. Comparing base (5be58f6) to head (70cea3e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5be58f6) and HEAD (70cea3e). Click for more details.

HEAD has 553 uploads less than BASE
Flag BASE (5be58f6) HEAD (70cea3e)
cpu 147 21
lightning 106 16
pytest 87 2
python3.9 43 6
python3.10 42 6
lightning_fabric 25 0
gpu 4 2
python3.11 42 6
python3.12 20 3
pytorch2.1 38 12
pytest-full 64 21
pytorch2.3 9 3
pytorch_lightning 20 7
pytorch2.2 9 3
pytorch2.4 8 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20260     +/-   ##
=========================================
- Coverage      89%      81%     -8%     
=========================================
  Files         267      264      -3     
  Lines       23084    23009     -75     
=========================================
- Hits        20585    18606   -1979     
- Misses       2499     4403   +1904     

@Borda Borda merged commit 474bdd0 into Lightning-AI:master Sep 30, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make RichProgressBar visible for both light and dark theme by default
2 participants