add LED indicator table #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add LED indicator table for quick overview of LED functions
martinjaeger
reviewed
Oct 5, 2022
Comment on lines
+51
to
+57
| | LED ID | ON | | ||
| |--------|-------------------------------| | ||
| | LED 1 | battery SOC low | | ||
| | LED 2 | battery SOC middle | | ||
| | LED 3 | battery SOC high | | ||
| | LED 4 | Load and USB port enabled | | ||
| | LED 5 | free for costum configuration | |
There was a problem hiding this comment.
Did you double-check whether this renders correctly if built with Pandoc? They have some special way to configure tables IIRC. And unfortunately it's not standardized in Markdown.
Just wondering because the table in the specs page is formatted differently.
There was a problem hiding this comment.
thanks for the hint. i didn't check it. here is the new suggestion. would this work
Suggested change
| | LED ID | ON | | |
| |--------|-------------------------------| | |
| | LED 1 | battery SOC low | | |
| | LED 2 | battery SOC middle | | |
| | LED 3 | battery SOC high | | |
| | LED 4 | Load and USB port enabled | | |
| | LED 5 | free for costum configuration | | |
| ------------------------------------ | |
| LED No. Value = ON | |
| -------------- --------------------- | |
| LED 1 battery SOC low | |
| LED 2 battery SOC middle | |
| LED 3 battery SOC high | |
| LED 4 Load and USB port enabled | |
| LED 5 free for costum configuration |
There was a problem hiding this comment.
I'm not sure if the new suggestion works. Did a quick check and for some reason pandoc doesn't want to create the PDF at all. For the HTML page even the first suggestion seems to work.
However, the content looks wrong. If LED1 is on, would the SOC not be high?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add LED indicator table for quick overview of LED functions