Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pylint, black and isort with ruff #1059

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

AnkurPrabhu
Copy link
Contributor

@AnkurPrabhu AnkurPrabhu commented Oct 30, 2023

Issue Link: #778 @derneuere
what has been done :

  • edited .pre-commit-config.yaml file for adding ruff
  • edited pyproject.toml for the same

@derneuere
Copy link
Member

It replaces isort, black and flake8. Ideally we should only have ruff at the end. You also need to remove isort, black and flake8 it and add ruff in requirements.dev.txt

@AnkurPrabhu
Copy link
Contributor Author

It replaces isort, black and flake8. Ideally we should only have ruff at the end. You also need to remove isort, black and flake8 it and add ruff in requirements.dev.txt

yes got it i just raised the pr to make sure i am in the right direction will add it in requirements.txt

Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AnkurPrabhu
Copy link
Contributor Author

@derneuere
so as far as i have researched the only thing i have not added is pylint. The code for pylint in .toml file is 'PL' once i add this it throws a lot of errors so didnt add it here ..so need some guidance here as in what should i do here.

@derneuere
Copy link
Member

According to the documentation ruff provides pylint rules and acts as a replacement. Without a specific error message, I can't give you more guidance. I think you should probably just fix the error.

@AnkurPrabhu
Copy link
Contributor Author

According to the documentation ruff provides pylint rules and acts as a replacement. Without a specific error message, I can't give you more guidance. I think you should probably just fix the error.

okay will try to fix all the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants