Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sym/cmp for crystals with a grounded case #100

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

ii8
Copy link
Contributor

@ii8 ii8 commented Jul 24, 2023

SUMMARY

add crystals with ground connection

CHECKLIST
  • I have read and followed the library conventions¹.
  • I already used the new library elements in a design and verified their correctness (optional).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

@ubruhin ubruhin added addition New library element. ready for review Waiting for review by maintainers. labels Aug 25, 2023
@ubruhin ubruhin self-assigned this Aug 25, 2023
@ubruhin
Copy link
Contributor

ubruhin commented Sep 4, 2023

@ii8 Thanks for this contribution and sorry for the delay! Just one quick question: Do you have any objections in making the symbol more compact and keeping the same orientation as the other crystal symbol?

image

(Maybe some day we should rotate them both to have GND at bottom, but the project library updater is not able yet to auto-correct the rotation after an update so it's better to keep the rotation of the existing crystal for now.)

If you're fine with this change, I'd commit it and merge this.

@ii8
Copy link
Contributor Author

ii8 commented Sep 5, 2023

Yea that's fine

@ubruhin ubruhin merged commit 01c2b91 into LibrePCB-Libraries:master Sep 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition New library element. ready for review Waiting for review by maintainers.
Development

Successfully merging this pull request may close these issues.

2 participants