[WARNING] Create a warning free build (#99)

LibertyGlobal · Oct 25, 2021 · d69cbd5 · d69cbd5
1 parent c195b46
commit d69cbd5
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 15 deletions.
diff --git a/Packager/Packager.cpp b/Packager/Packager.cpp
@@ -89,7 +89,7 @@ namespace {
         return (string());
     }
 
-    void Packager::Inbound(Web::Request& request)
+    void Packager::Inbound(VARIABLE_IS_NOT_USED Web::Request& request)
     {
     }
 

diff --git a/WebKitBrowser/InjectedBundle/main.cpp b/WebKitBrowser/InjectedBundle/main.cpp
@@ -213,7 +213,9 @@ static class PluginHost {
 #endif
 
     }
-    static void pageCreatedCallback(WebKitWebExtension*, WebKitWebPage* page, PluginHost* host)
+    static void pageCreatedCallback(VARIABLE_IS_NOT_USED WebKitWebExtension* webExtension,
+                                    WebKitWebPage* page,
+                                    VARIABLE_IS_NOT_USED PluginHost* host)
     {
         g_signal_connect(page, "console-message-sent",
                 G_CALLBACK(consoleMessageSentCallback), nullptr);
@@ -222,7 +224,7 @@ static class PluginHost {
         g_signal_connect(page, "send-request",
                 G_CALLBACK(sendRequestCallback), nullptr);
     }
-    static void consoleMessageSentCallback(WebKitWebPage* page, WebKitConsoleMessage* message)
+    static void consoleMessageSentCallback(VARIABLE_IS_NOT_USED WebKitWebPage* page, WebKitConsoleMessage* message)
     {
         string messageString = Core::ToString(webkit_console_message_get_text(message));
         uint64_t line = static_cast<uint64_t>(webkit_console_message_get_line(message));

diff --git a/WebKitBrowser/WebKitImplementation.cpp b/WebKitBrowser/WebKitImplementation.cpp
@@ -1085,7 +1085,7 @@ static GSourceFuncs _handlerIntervention =
                 return G_SOURCE_REMOVE;
             },
             this,
-            [](gpointer customdata) {
+            [](gpointer) {
             });
             return Core::ERROR_NONE;
         }
@@ -1360,7 +1360,7 @@ static GSourceFuncs _handlerIntervention =
             _adminLock.Unlock();
         }
 
-        uint32_t Reset(const resettype type) override
+        uint32_t Reset(VARIABLE_IS_NOT_USED const resettype type) override
         {
             return Core::ERROR_UNAVAILABLE;
         }
@@ -1385,17 +1385,17 @@ static GSourceFuncs _handlerIntervention =
             return Core::ERROR_NONE;
         }
 
-        uint32_t ContentLink(const string& link) override
+        uint32_t ContentLink(VARIABLE_IS_NOT_USED const string& link) override
         {
             return Core::ERROR_UNAVAILABLE;
         }
 
-        uint32_t LaunchPoint(launchpointtype& point) const override
+        uint32_t LaunchPoint(VARIABLE_IS_NOT_USED launchpointtype& point) const override
         {
             return Core::ERROR_UNAVAILABLE;
         }
 
-        uint32_t LaunchPoint(const launchpointtype&) override
+        uint32_t LaunchPoint(VARIABLE_IS_NOT_USED const launchpointtype&) override
         {
             return Core::ERROR_UNAVAILABLE;
         }
@@ -2037,12 +2037,12 @@ static GSourceFuncs _handlerIntervention =
         {
             browser->OnURLChanged(Core::ToString(webkit_web_view_get_uri(webView)));
         }
-        static void loadChangedCallback(WebKitWebView* webView, WebKitLoadEvent loadEvent, WebKitImplementation* browser)
+        static void loadChangedCallback(VARIABLE_IS_NOT_USED WebKitWebView* webView, WebKitLoadEvent loadEvent, WebKitImplementation* browser)
         {
             if (loadEvent == WEBKIT_LOAD_FINISHED)
                 browser->OnLoadFinished();
         }
-        static void webProcessTerminatedCallback(WebKitWebView* webView, WebKitWebProcessTerminationReason reason)
+        static void webProcessTerminatedCallback(VARIABLE_IS_NOT_USED WebKitWebView* webView, WebKitWebProcessTerminationReason reason)
         {
             switch (reason) {
             case WEBKIT_WEB_PROCESS_CRASHED:
@@ -2057,25 +2057,25 @@ static GSourceFuncs _handlerIntervention =
             }
             exit(1);
         }
-        static void closeCallback(WebKitWebView*, WebKitImplementation* browser)
+        static void closeCallback(VARIABLE_IS_NOT_USED WebKitWebView* webView, WebKitImplementation* browser)
         {
             browser->NotifyClosure();
         }
-        static gboolean decidePermissionCallback(WebKitWebView*, WebKitPermissionRequest* permissionRequest)
+        static gboolean decidePermissionCallback(VARIABLE_IS_NOT_USED WebKitWebView* webView, WebKitPermissionRequest* permissionRequest)
         {
             webkit_permission_request_allow(permissionRequest);
             return TRUE;
         }
-        static gboolean showNotificationCallback(WebKitWebView*, WebKitNotification* notification, WebKitImplementation* browser)
+        static gboolean showNotificationCallback(VARIABLE_IS_NOT_USED WebKitWebView* webView, WebKitNotification* notification, VARIABLE_IS_NOT_USED WebKitImplementation* browser)
         {
             TRACE_GLOBAL(HTML5Notification, (_T("%s - %s"), webkit_notification_get_title(notification), webkit_notification_get_body(notification)));
             return FALSE;
         }
-        static WebKitWebView* createWebViewForAutomationCallback(WebKitAutomationSession* session, WebKitImplementation* browser)
+        static WebKitWebView* createWebViewForAutomationCallback(VARIABLE_IS_NOT_USED WebKitAutomationSession* session, WebKitImplementation* browser)
         {
             return browser->_view;
         }
-        static void automationStartedCallback(WebKitWebContext* context, WebKitAutomationSession* session, WebKitImplementation* browser)
+        static void automationStartedCallback(VARIABLE_IS_NOT_USED WebKitWebContext* context, WebKitAutomationSession* session, WebKitImplementation* browser)
         {
             WebKitApplicationInfo *info = webkit_application_info_new();
             webkit_application_info_set_name(info, "WPEWebKitBrowser");
-Original file line number
+Diff line change
@@ Expand Up / @@ -89,7 +89,7 @@ namespace { @@
             return (string());
         }
-        void Packager::Inbound(Web::Request& request)
+        void Packager::Inbound(VARIABLE_IS_NOT_USED Web::Request& request)
         {
         }
@@ Expand Down @@