Skip to content

Commit

Permalink
Call PID clean up on checkpoint and restore timeout
Browse files Browse the repository at this point in the history
Make sure dump is removed, since the worker exit
signal may come after the clean up of checkpoint data and
be not effective.
  • Loading branch information
adrianM27 authored and mkozlowski committed Jul 22, 2024
1 parent 5fd208c commit 85c3086
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions memcr.c
Original file line number Diff line number Diff line change
Expand Up @@ -2512,6 +2512,7 @@ static int checkpoint_procedure_service(int checkpointSocket, int cd, int pid, i
// unable to read response from worker, kill both
kill(pid, SIGKILL);
kill(worker_pid, SIGKILL);
cleanup_pid(pid);
send_response_to_client(cd, MEMCR_ERROR_GENERAL);
return MEMCR_ERROR_GENERAL;
}
Expand Down Expand Up @@ -2551,6 +2552,7 @@ static void restore_procedure_service(int cd, struct service_command svc_cmd, in
// unable to read response from worker, kill both
kill(svc_cmd.pid, SIGKILL);
kill(worker_pid, SIGKILL);
cleanup_pid(svc_cmd.pid);
ret = -1;
}

Expand Down

0 comments on commit 85c3086

Please sign in to comment.