Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

186828135: Moves exception into CompletableFuture context #49

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

julian-amplica
Copy link
Collaborator

This change:

  • Fixes the healthcheck issue
  • Moves a throw into the CompletableFuture context so we can use all the CompletableFuture methods for exception handling without any need for try-catch.
  • Does not break any tests in this repo, saas-frequency-client, or custodial-wallet
  • However, removing a possible throw scenario and adding a new type of exception that the CompletableFuture may resolve to has the possibility to mess up MeWe, so we may want to increment the version number accordingly and discuss this change with them

Copy link
Collaborator

@pfrank13 pfrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite it being a behavior change this seems legit from our usages, we will get this as a minor version change (or the like) and people can fork before that if needs to be but this behavior is more "correct" IMO

@pfrank13 pfrank13 merged commit 08f4988 into unfinished_develop Jan 19, 2024
1 check passed
@pfrank13 pfrank13 deleted the 186828135-plug-escape-hatch branch January 19, 2024 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants