This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix/Arm mac support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-amplica
requested review from
Ajaxan,
abadaa,
pfrank13 and
tedward111
pfrank13
approved these changes
Nov 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed issues building this repo on my M2 mac that are fixed by these changes. There is a possibility that these changes may impact Haswell Intel Macs—which will now target
x86_64hinstead ofx86_64—but it should not change behavior (although may increase performance).I'm looking for at least 1-2 folks to test this branch out on different machines before merging. Thanks!